Bug 133715

Summary: [EFL][WK2] Add missing test cases for EWK2ViewTest
Product: WebKit Reporter: Shivakumar J M <shiva.jm>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi, ossy, rakuco, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
gyuyoung.kim: review+
Patch for landing none

Description Shivakumar J M 2014-06-10 20:45:34 PDT
Add missing test cases for ewk_view.h APIs, ewk_view_stop(), ewk_view_html_string_load(), ewk_view_theme_get(), ewk_view_feed_touch_event(), ewk_view_text_find_highlight_clear(), ewk_view_text_find(), ewk_view_text_matches_count(), ewk_view_page_contents_get(), ewk_view_script_execute().
Comment 1 Shivakumar J M 2014-06-11 03:24:34 PDT
Created attachment 232858 [details]
Patch

Patch for Adding the missing test cases for EWK2ViewTest
Comment 2 Gyuyoung Kim 2014-06-11 03:31:20 PDT
Comment on attachment 232858 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232858&action=review

LGTM except for minor nits.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:414
> +

Unnecessary line.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:1052
> +    EXPECT_FALSE(ewk_view_page_contents_get(webView(), (Ewk_Page_Contents_Type) 2, PageContentsAsStringCallback, 0));

Use static_cast<Ewk_Page_Contents_Type> instead of (Ewk_Page_Contents_Type).
Comment 3 Shivakumar J M 2014-06-11 03:51:11 PDT
Created attachment 232860 [details]
Patch for landing

Updated with review comments
Comment 4 WebKit Commit Bot 2014-06-11 04:56:39 PDT
Comment on attachment 232860 [details]
Patch for landing

Clearing flags on attachment: 232860

Committed r169801: <http://trac.webkit.org/changeset/169801>
Comment 5 WebKit Commit Bot 2014-06-11 04:56:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Csaba Osztrogon√°c 2014-06-11 11:45:37 PDT
(In reply to comment #4)
> (From update of attachment 232860 [details])
> Clearing flags on attachment: 232860
> 
> Committed r169801: <http://trac.webkit.org/changeset/169801>

It broke the EFL WK2 build:

CMake Error at Source/WebKit2/PlatformEfl.cmake:502 (add_executable):
  add_executable cannot create target "test_ewk2_view" because another target
  with the same name already exists.  The existing target is an executable
  created in source directory
  "/mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2".
  See documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  Source/cmake/WebKitMacros.cmake:4 (include)
  Source/cmake/WebKitMacros.cmake:203 (INCLUDE_IF_EXISTS)
  Source/WebKit2/CMakeLists.txt:688 (WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS)
Comment 7 Gyuyoung Kim 2014-06-11 18:20:29 PDT
(In reply to comment #6)
> (In reply to comment #4)
> > (From update of attachment 232860 [details] [details])
> > Clearing flags on attachment: 232860
> > 
> > Committed r169801: <http://trac.webkit.org/changeset/169801>
> 
> It broke the EFL WK2 build:
> 
> CMake Error at Source/WebKit2/PlatformEfl.cmake:502 (add_executable):
>   add_executable cannot create target "test_ewk2_view" because another target
>   with the same name already exists.  The existing target is an executable
>   created in source directory
>   "/mnt/buildbot/WebKit-BuildSlave/efl-linux-64-release-wk2/build/Source/WebKit2".
>   See documentation for policy CMP0002 for more details.
> Call Stack (most recent call first):
>   Source/cmake/WebKitMacros.cmake:4 (include)
>   Source/cmake/WebKitMacros.cmake:203 (INCLUDE_IF_EXISTS)
>   Source/WebKit2/CMakeLists.txt:688 (WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS)

Weird. There is no this build problem locally. Restarted efl-wk2 bot.
Comment 8 Shivakumar J M 2014-06-11 21:57:08 PDT
yes observed the same thing, There is no such build problem in my local machine