Bug 133705 – Don't create a HashTable for JSObjects that use eager reification

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

Don't create a HashTable for JSObjects that use eager reification

[Sam Weinig]

Created attachment 232825 [details]
Patch

[Geoffrey Garen]

Comment on attachment 232825 [details]
Patch

r=me

[Build Bot]

Comment on attachment 232825 [details]
Patch

Attachment 232825 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5765206927998976

New failing tests:
compositing/checkerboard.html
compositing/absolute-inside-out-of-view-fixed.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
animations/added-while-suspended.html
animations/animation-add-events-in-handler.html
animations/additive-transform-animations.html
animations/3d/replace-filling-transform.html
accessibility/accessibility-object-detached.html
accessibility/alt-tag-on-image-with-nonimage-role.html
compositing/bounds-in-flipped-writing-mode.html
accessibility/accessibility-node-reparent.html
animations/animation-border-overflow.html
http/tests/appcache/abort-cache-onchecking-resource-404.html
animations/animation-controller-drt-api.html
animations/3d/change-transform-in-end-event.html
compositing/absolute-position-changed-with-composited-parent-layer.html
compositing/absolute-position-changed-in-composited-layer.html
canvas/philip/tests/2d.canvas.readonly.html
http/tests/appcache/abort-cache-onchecking-manifest-404.html
canvas/philip/tests/2d.canvas.reference.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.5.html
http/tests/appcache/404-resource.html
animations/3d/transform-origin-vs-functions.html
accessibility/accessibility-node-memory-management.html
http/tests/appcache/abort-cache-onchecking.html
accessibility/adjacent-continuations-cause-assertion-failure.html
http/tests/appcache/404-manifest.html
canvas/philip/tests/2d.clearRect+fillRect.basic.html
canvas/philip/tests/2d.clearRect+fillRect.alpha0.html

[Build Bot]

Created attachment 232841 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Sam Weinig]

Committed r169789: <http://trac.webkit.org/changeset/169789>

[Ryosuke Niwa]

Looks like these test failures reported by mac-wk2 bots are real:
http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r169789%20(6543)/results.html

[Andy Estes]

This broke the build on Yosemite. I fixed it in http://trac.webkit.org/changeset/169800, but you should check to see if my fix makes sense.

[Daniel Bates]

For completeness, a build fix was committed by Sam Weinig in <http://trac.webkit.org/changeset/169792>

[Daniel Bates]

(In reply to comment #5)
> Committed r169789: <http://trac.webkit.org/changeset/169789>

This regressed the layout test Layout Test js/dom/webidl-type-mapping.html. See bug #133736 for more details.