Bug 133699 – Web Inspector: TypeError when hovering over "Show All Nodes" button in the Dom Tree inspector

• Component: Web Inspector
• Status: RESOLVED FIXED

[Jonathan Wells]

Created attachment 232815 [details]
Test case

Each mouseover throws this error:

[Error] TypeError: undefined is not a function (evaluating 'element._createTooltipForNode()')
	_onmousemove (DOMTreeOutline.js, line 313)
	(anonymous function) ([native code], line 0)

To reproduce, in the attached 501nodes.html file, inspect the dom and mouse over the "Show All Nodes" button below.

[Radar WebKit Bug Importer]

<rdar://problem/17257874>

[Jonathan Wells]

Created attachment 233668 [details]
[PATCH] Fix attempt.

[Build Bot]

Comment on attachment 233668 [details]
[PATCH] Fix attempt.

Attachment 233668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4667063406690304

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html

[Build Bot]

Created attachment 233675 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Jonathan Wells]

This test failure is not caused by this patch.

[Geoffrey Garen]

Comment on attachment 233668 [details]
[PATCH] Fix attempt.

View in context: https://bugs.webkit.org/attachment.cgi?id=233668&action=review

> Source/WebInspectorUI/UserInterface/Views/DOMTreeOutline.js:313
> +            if (element.representedObject && !element.tooltip && element instanceof WebInspector.DOMTreeElement)
>                  element._createTooltipForNode();

I think it might be better just to test for the presence of the "_createTooltipForNode" property, instead of doing an instanceof check. This is basically a delegation protocol, and those usually work best when they are agnostic about the type of the target object, and only check whether the target object responds to the delegate function.

[Geoffrey Garen]

Also, can you add a Web Inspector regression test to this patch?

[Timothy Hatcher]

We don't have Web Inspector UI regression tests. We only have tests for the protocol and model layers.

[Jonathan Wells]

Committed r170389: <https://trac.webkit.org/changeset/170389>