REGRESSION (r169725): Several TextTrackCue tests became very flaky

• Component: Media
• Status: NEW ---

[Alexey Proskuryakov]

Multiple TextTrackCue tests have started to fail frequently on all Mac bots yesterday:

http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Fw3c%2Finterfaces%2FTextTrackCue%2FendTime.html

media/track/w3c/interfaces/TextTrackCue/align.html
media/track/w3c/interfaces/TextTrackCue/endTime.html
media/track/w3c/interfaces/TextTrackCue/id.html
media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html
media/track/w3c/interfaces/TextTrackCue/startTime.html
media/track/w3c/interfaces/TextTrackCue/track.html

[Andy Estes]

Skipped in r169767: http://trac.webkit.org/changeset/169767

[Andy Estes]

Changed from [ Skip ] to [ Pass Failure ] in r169771: http://trac.webkit.org/changeset/169771

[Simon Fraser (smfr)]

When they fail the TextTrack mode is "disabled".

[Simon Fraser (smfr)]

Mode is set to disabled via:

* thread #1: tid = 0xe6efb, 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213, queue = 'com.apple.main-thread', stop reason = breakpoint 10.1
  * frame #0: 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213
    frame #1: 0x000000010498f173 WebCore`WebCore::HTMLMediaElement::configureTextTrackGroup(this=0x0000000113833200, group=0x00007fff5fbfce90) + 2275 at HTMLMediaElement.cpp:3634
    frame #2: 0x00000001049819fb WebCore`WebCore::HTMLMediaElement::configureTextTracks(this=0x0000000113833200) + 1307 at HTMLMediaElement.cpp:3795
    frame #3: 0x000000010497da93 WebCore`WebCore::HTMLMediaElement::loadTimerFired(this=0x0000000113833200, =0x00000001138332c0) + 99 at HTMLMediaElement.cpp:799

[Brent Fulgham]

The system is determining that the tracks in the test are not a close enough match to the user's caption preferences, and is turning them all off.

1. DRT/WKTR should probably override these preferences.
2. The step to make the track "display" may need to happen in the onload handler, since it seems like that is firing before the property is being set.

[Simon Fraser (smfr)]

In DRT, CaptionUserPreferencesMediaAF::captionDisplayMode() is testing testingMode(), which is true in DRT, so captionDisplayMode() returns ForcedOnly. In MiniBrowser, it returns Automatic.

[Simon Fraser (smfr)]

Eric, this regressed with r169725. Please take a look.

[Eric Carlson]

Created attachment 232954 [details]
Proposed patch.

[Simon Fraser (smfr)]

Comment on attachment 232954 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:1580
> +    LOG(Media, "HTMLMediaElement::textTrackModeChanged - mode = %s", String(track->mode()).utf8().data());

It would have been helpful when debugging this if logging had included data on which track was being logged; either the value of |this| or some kind of track ID.

[Alexey Proskuryakov]

Comment on attachment 232954 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Please remove the tests from TestExpectations.

[Build Bot]

Comment on attachment 232954 [details]
Proposed patch.

Attachment 232954 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4652199305019392

New failing tests:
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 232961 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 232954 [details]
Proposed patch.

Attachment 232954 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4661729837449216

New failing tests:
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 232968 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 232954 [details]
Proposed patch.

Attachment 232954 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6058470381977600

New failing tests:
media/video-trackmenu-selection.html

[Build Bot]

Created attachment 232993 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Simon Fraser (smfr)]

Looks like this breaks media/video-trackmenu-selection.html. What's the plan?

[Alexey Proskuryakov]

Ping?

[Alexey Proskuryakov]

Is this patch still relevant?