Summary: | REGRESSION (r169725): Several TextTrackCue tests became very flaky | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||||||
Status: | NEW --- | ||||||||||||
Severity: | Normal | CC: | aestes, bfulgham, buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio, simon.fraser | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=142484 | ||||||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-06-10 11:24:09 PDT
Skipped in r169767: http://trac.webkit.org/changeset/169767 Changed from [ Skip ] to [ Pass Failure ] in r169771: http://trac.webkit.org/changeset/169771 When they fail the TextTrack mode is "disabled". Mode is set to disabled via: * thread #1: tid = 0xe6efb, 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213, queue = 'com.apple.main-thread', stop reason = breakpoint 10.1 * frame #0: 0x0000000105d13097 WebCore`WebCore::TextTrack::setMode(this=0x000000010ff2d390, mode=0x0000000117703270) + 23 at TextTrack.cpp:213 frame #1: 0x000000010498f173 WebCore`WebCore::HTMLMediaElement::configureTextTrackGroup(this=0x0000000113833200, group=0x00007fff5fbfce90) + 2275 at HTMLMediaElement.cpp:3634 frame #2: 0x00000001049819fb WebCore`WebCore::HTMLMediaElement::configureTextTracks(this=0x0000000113833200) + 1307 at HTMLMediaElement.cpp:3795 frame #3: 0x000000010497da93 WebCore`WebCore::HTMLMediaElement::loadTimerFired(this=0x0000000113833200, =0x00000001138332c0) + 99 at HTMLMediaElement.cpp:799 The system is determining that the tracks in the test are not a close enough match to the user's caption preferences, and is turning them all off. 1. DRT/WKTR should probably override these preferences. 2. The step to make the track "display" may need to happen in the onload handler, since it seems like that is firing before the property is being set. In DRT, CaptionUserPreferencesMediaAF::captionDisplayMode() is testing testingMode(), which is true in DRT, so captionDisplayMode() returns ForcedOnly. In MiniBrowser, it returns Automatic. Eric, this regressed with r169725. Please take a look. Created attachment 232954 [details]
Proposed patch.
Comment on attachment 232954 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review > Source/WebCore/html/HTMLMediaElement.cpp:1580 > + LOG(Media, "HTMLMediaElement::textTrackModeChanged - mode = %s", String(track->mode()).utf8().data()); It would have been helpful when debugging this if logging had included data on which track was being logged; either the value of |this| or some kind of track ID. Comment on attachment 232954 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=232954&action=review > Source/WebCore/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Please remove the tests from TestExpectations. Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4652199305019392 New failing tests: media/video-trackmenu-selection.html Created attachment 232961 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4661729837449216 New failing tests: media/video-trackmenu-selection.html Created attachment 232968 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 232954 [details] Proposed patch. Attachment 232954 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6058470381977600 New failing tests: media/video-trackmenu-selection.html Created attachment 232993 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Looks like this breaks media/video-trackmenu-selection.html. What's the plan? Ping? Is this patch still relevant? |