| Summary: | Serialize ResourceRequests without platform request | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Page Loading | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, buildbot, commit-queue, rniwa, sam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2014-06-10 09:01:54 PDT
Created attachment 232789 [details]
patch
Attachment 232789 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:295: Multi line control clauses should use braces. [whitespace/braces] [4]
ERROR: Source/WebCore/platform/network/ResourceRequestBase.h:297: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 2 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 232789 [details]
patch
Neat.
Please wait for WebKit2 tests to pass (or fail in a usual way, EWS is not feeling well recently).
Comment on attachment 232789 [details] patch Attachment 232789 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5728664004067328 New failing tests: media/track/w3c/interfaces/TextTrackCue/id.html media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html media/track/w3c/interfaces/TextTrackCue/track.html media/track/w3c/interfaces/TextTrackCue/startTime.html media/track/w3c/interfaces/TextTrackCue/endTime.html media/track/w3c/interfaces/TextTrackCue/align.html Created attachment 232797 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
This changes nothing for WK1 so those failures are probably not related. Definitely unrelated, these tests became very flaky yesterday (bug 133686). |