Bug 133677

Summary:

Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer

Product:

WebKit

Reporter:

Zan Dobersek <zan>

Component:

New Bugs

Assignee:

Zan Dobersek <zan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Zan Dobersek 2014-06-09 23:13:15 PDT

Page::findStringMatchingRanges() should take Vector<RefPtr<Range>> by reference instead of pointer

Comment 1 Zan Dobersek 2014-06-09 23:15:18 PDT

Created attachment 232772 [details]
Patch

Comment 2 Anders Carlsson 2014-06-11 20:21:26 PDT

Comment on attachment 232772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232772&action=review

> Source/WebCore/page/Page.cpp:542
> +void Page::findStringMatchingRanges(const String& target, FindOptions options, int limit, Vector<RefPtr<Range>>& matchRanges, int& indexForSelection)

Can this be a const reference?

Comment 3 Zan Dobersek 2014-06-14 10:56:19 PDT

Comment on attachment 232772 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232772&action=review

>> Source/WebCore/page/Page.cpp:542
>> +void Page::findStringMatchingRanges(const String& target, FindOptions options, int limit, Vector<RefPtr<Range>>& matchRanges, int& indexForSelection)
> 
> Can this be a const reference?

No, that would clash with Editor::countMatchesForText() which expects a pointer to a non-const Vector.

Comment 4 Zan Dobersek 2014-06-14 11:01:04 PDT

Created attachment 233112 [details]
Patch

Comment 5 Zan Dobersek 2014-06-16 09:42:59 PDT

Comment on attachment 233112 [details]
Patch

Clearing flags on attachment: 233112

Committed r170012: <http://trac.webkit.org/changeset/170012>

Comment 6 Zan Dobersek 2014-06-16 09:43:06 PDT

All reviewed patches have been landed.  Closing bug.