Bug 13366

Summary: REGRESSION (r10935): AOL beta music player doesn't play
Product: WebKit Reporter: Troy Brandt <troyb>
Component: DOMAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: dacarson, ddkilzer, mitz
Priority: P1 Keywords: InRadar, Regression
Version: 523.x (Safari 3)   
Hardware: Mac   
OS: OS X 10.4   
URL: http://music.aol.com/songs/newsongs
Description Flags
The qt script file referenced in Javascript console none

Description Troy Brandt 2007-04-16 15:31:19 PDT
If you visit the page above you'll be presented with a list of songs. Click the play link to the right to open a pop-up with the player contained within. 

In Safari Version 2.0.4 (419.3) the song immediately starts playing. In WebKit r20897 the player appears to load but doesn't ever start playing and the controls don't work. It looks like it fails to load up the song for play. 

I'll included a reduction however someone may be able to get it reduced down a bit further.
Comment 1 Troy Brandt 2007-04-16 15:33:34 PDT
Created attachment 14056 [details]
Comment 2 David Carson 2007-06-15 21:16:35 PDT
According to the Javascript console, there was a TypeError: NULL value on line 1382 of:
Comment 3 David Carson 2007-06-15 21:17:38 PDT
Created attachment 15077 [details]
The qt script file referenced in Javascript console
Comment 5 David Carson 2007-07-05 22:38:15 PDT
using nightly.webkit.org, I went back to the first release, r11976, and the problem still exists there.
Comment 6 David Carson 2007-07-16 11:01:37 PDT
regression was introduced in r10936 when correcting the bug:
Added mitz to CC list as he corrected the bug
Comment 7 David Kilzer (:ddkilzer) 2007-07-17 07:38:35 PDT
Code change:  http://trac.webkit.org/projects/webkit/changeset/10935
Layout test: http://trac.webkit.org/projects/webkit/changeset/10936

Comment 8 David Kilzer (:ddkilzer) 2007-07-17 07:38:54 PDT
Comment 9 David Kilzer (:ddkilzer) 2007-07-18 17:10:17 PDT
7/18/07 3:56 PM Anders Carlsson:
Here's the problem:

The qt.js file has a typo, causing it to write

                + "\" width=" + width + " height=" + height

this will result in a tag with the name <embed" (note the extra character at the end). This causes Safari to not recognize the embed element.

Comment 10 David Kilzer (:ddkilzer) 2007-07-18 17:11:07 PDT
Should we evangelize AOL to fix this issue as well?

Comment 11 David Kilzer (:ddkilzer) 2007-07-18 17:12:09 PDT
Fixed by andersca in r 24429.

Comment 12 David Kilzer (:ddkilzer) 2007-07-18 21:58:26 PDT
(In reply to comment #10)
> Should we evangelize AOL to fix this issue as well?

Sent feedback to AOL via the "Send Us Feedback" link on http://music.aol.com/songs/newsongs.