Summary: | HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | Bindings | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, kling, mhahnenberg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2014-06-09 13:09:43 PDT
Created attachment 232726 [details]
Patch
Comment on attachment 232726 [details]
Patch
r=me
You might have to rebaseline bindings tests too. Committed r169709: <http://trac.webkit.org/changeset/169709> Comment on attachment 232726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232726&action=review > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:645 > + return 1 if $interfaceName =~ "List" && !($interfaceName =~ "Element"); Nit: "!~" operator. <http://perldoc.perl.org/perlop.html#Binding-Operators> Binary "!~" is just like "=~" except the return value is negated in the logical sense. |