Bug 133653

Summary: HTML*ListElement wrappers have custom getOwnPropertySlot()s for no good reason.
Product: WebKit Reporter: Andreas Kling <kling>
Component: BindingsAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, commit-queue, kling, mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mhahnenberg: review+

Description Andreas Kling 2014-06-09 13:09:43 PDT 
Patchy patch coming.
Comment 1 Andreas Kling 2014-06-09 13:10:10 PDT 
Created attachment 232726 [details]
Patch
Comment 2 Mark Hahnenberg 2014-06-09 13:11:30 PDT 
Comment on attachment 232726 [details]
Patch

r=me
Comment 3 Mark Hahnenberg 2014-06-09 13:11:53 PDT 
You might have to rebaseline bindings tests too.
Comment 4 Andreas Kling 2014-06-09 13:18:40 PDT 
Committed r169709: <http://trac.webkit.org/changeset/169709>
Comment 5 Joseph Pecoraro 2014-06-09 14:09:57 PDT 
Comment on attachment 232726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232726&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:645
> +    return 1 if $interfaceName =~ "List" && !($interfaceName =~ "Element");

Nit: "!~" operator.

<http://perldoc.perl.org/perlop.html#Binding-Operators>
Binary "!~" is just like "=~" except the return value is negated in the logical sense.