Summary: | Expose Touch radius | ||
---|---|---|---|
Product: | WebKit | Reporter: | Rick Byers <rbyers> |
Component: | UI Events | Assignee: | Benjamin Poulain <benjamin> |
Status: | NEW --- | ||
Severity: | Normal | CC: | dino, graouts, laszlo.gombos, sam, stumrob, syoichi, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Rick Byers
2014-06-09 06:57:26 PDT
Yep, this is worth looking into. I agree with the rationale for pageX instead of screenX. A drawing/annotation widget could appear anywhere on a page, at any scale factor, and it should be all the same from JavaScript. How should this affect Document.createTouch()? Is it specified? The change to createTouch is not specified but should be (in practice we see barely any use of this API, so I haven't invested much in it). The blink implementation here is unchanged from WebKit (except that I just changed all our 'long' co-ordinates to 'double'), so WebKit already has the same API a blink here, eg: https://trac.webkit.org/browser/trunk/Source/WebCore/dom/Document.idl#L335 [ReturnNewObject, RaisesException] Touch createTouch([Default=Undefined] optional DOMWindow window, [Default=Undefined] optional EventTarget target, [Default=Undefined] optional long identifier, [Default=Undefined] optional long pageX, [Default=Undefined] optional long pageY, [Default=Undefined] optional long screenX, [Default=Undefined] optional long screenY, [Default=Undefined] optional long webkitRadiusX, [Default=Undefined] optional long webkitRadiusY, [Default=Undefined] optional unrestricted float webkitRotationAngle, [Default=Undefined] optional unrestricted float webkitForce); Sounds good. I see iOS 10.3 exposes radiusX/radiusY now (and from http://rbyers.net/paint.html it seems to be hooked up to the native radius). Should this be marked Fixed now? Was 10.3 the first version or was it there previously before I noticed? |