Summary: | [MediaStream] Add getTracks() support to MediaStream. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kiran <kiran.guduru> | ||||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, hta, jer.noble, kondapallykalyan, lucas.de.marchi, philipj, rniwa, sergio, tommyw | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Kiran
2014-06-09 05:04:57 PDT
Created attachment 232702 [details]
[MediaStream] add getTracks support to MediaStream
Add patch that implements getTracks() in MediaStream.
Comment on attachment 232702 [details] [MediaStream] add getTracks support to MediaStream View in context: https://bugs.webkit.org/attachment.cgi?id=232702&action=review > LayoutTests/fast/mediastream/MediaStream-getTracks.html:42 > + tryAddTrack(stream2, audioTrack); Nit: it would be nice to log streams being added so the test results are self documenting. Created attachment 232767 [details]
[MediaStream] add getTracks support to MediaStream
Added extra logging in test file as per the review comments.
Comment on attachment 232767 [details] [MediaStream] add getTracks support to MediaStream Attachment 232767 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4514643447906304 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 232776 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 232778 [details]
[MediaStream] add getTracks support to MediaStream
Comment on attachment 232778 [details] [MediaStream] add getTracks support to MediaStream Clearing flags on attachment: 232778 Committed r169743: <http://trac.webkit.org/changeset/169743> Patch got landed, so closing the bug. |