Bug 133623

Summary: [Cocoa] WKScriptMessage should include the frame the message is from
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Sam Weinig 2014-06-08 16:02:08 PDT 
[Cocoa] WKScriptMessage should include the frame the message is from
Comment 1 Sam Weinig 2014-06-08 16:05:15 PDT 
Created attachment 232691 [details]
Patch
Comment 2 mitz 2014-06-08 16:07:32 PDT 
Comment on attachment 232691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232691&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKScriptMessage.mm:32
>  #import "WeakObjCPtr.h"
> +#import "WKFrameInfo.h"

K < e

> Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:108
> +        WKWebView* webView = fromWebPageProxy(page);

Is this necessary?
Comment 3 Sam Weinig 2014-06-08 16:14:21 PDT 
(In reply to comment #2)
> (From update of attachment 232691 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232691&action=review
> 
> > Source/WebKit2/UIProcess/API/Cocoa/WKScriptMessage.mm:32
> >  #import "WeakObjCPtr.h"
> > +#import "WKFrameInfo.h"
> 
> K < e

Will fix.

> > Source/WebKit2/UIProcess/API/Cocoa/WKUserContentController.mm:108
> > +        WKWebView* webView = fromWebPageProxy(page);
> 
> Is this necessary?

Nah.
Comment 4 Sam Weinig 2014-06-08 16:14:35 PDT 
<rdar://problem/17210226>
Comment 5 Sam Weinig 2014-06-08 16:22:11 PDT 
Committed revision 169684