Bug 133619

Summary:

[Mac] checkboxes and radio buttons animate incorrectly

Product:

WebKit

Reporter:

Dean Jackson <dino>

Component:

New Bugs

Assignee:

Dean Jackson <dino>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Dean Jackson 2014-06-08 14:20:18 PDT

[Mac] checkboxes and radio buttons animate incorrectly

Comment 1 Dean Jackson 2014-06-08 14:25:20 PDT

Created attachment 232685 [details]
Patch

Comment 2 Sam Weinig 2014-06-08 14:30:48 PDT

Comment on attachment 232685 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232685&action=review

> Source/WebCore/platform/mac/ThemeMac.mm:304
> +static const std::array<FloatSize, 3>& checkboxOffsets()

I think this could use a comment explaining what they the offsets are used for.

> Source/WebCore/platform/mac/ThemeMac.mm:332
> +static const std::array<FloatSize, 3>& radioOffsets()

I think this could use a comment explaining what they the offsets are used for.

Comment 3 Dean Jackson 2014-06-08 17:03:14 PDT

Committed r169685: <http://trac.webkit.org/changeset/169685>