Bug 133618

Summary:

Reduce the overhead of updating the animatable style on ARMv7

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+, simon.fraser: commit-queue-

Benjamin Poulain

Reported 2014-06-08 14:19:48 PDT

Reduce the overhead of updating the animatable style on ARMv7

Attachments
Patch (6.02 KB, patch) 2014-06-08 14:38 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (6.33 KB, patch) 2014-06-09 16:14 PDT, Benjamin Poulain	no flags	Details Formatted Diff Diff
Patch (6.34 KB, patch) 2014-06-10 13:53 PDT, Benjamin Poulain	simon.fraser: review+ simon.fraser: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Benjamin Poulain

Comment 1 2014-06-08 14:38:09 PDT

Benjamin Poulain

Comment 2 2014-06-09 16:14:33 PDT

Benjamin Poulain

Comment 3 2014-06-10 13:53:09 PDT

Simon Fraser (smfr)

Comment 4 2014-06-10 18:19:31 PDT

Comment on attachment 232812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1066 > + CGFloat scaleFactor = contentZoomScale(self); > + [_contentView scaleFactorDidChange:scaleFactor]; Unrelated?

Tim Horton

Comment 5 2014-06-10 18:26:36 PDT

Comment on attachment 232812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review > Source/WebCore/ChangeLog:8 > + While udpating the style for animations, most of the time spent was pure calling overhead. updating

Benjamin Poulain

Comment 6 2014-06-10 20:36:26 PDT

Note You need to log in before you can comment on or make changes to this bug.