Bug 133618

Summary:

Reduce the overhead of updating the animatable style on ARMv7

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	simon.fraser: review+, simon.fraser: commit-queue-

Description Benjamin Poulain 2014-06-08 14:19:48 PDT

Reduce the overhead of updating the animatable style on ARMv7

Comment 1 Benjamin Poulain 2014-06-08 14:38:09 PDT

Created attachment 232686 [details]
Patch

Comment 2 Benjamin Poulain 2014-06-09 16:14:33 PDT

Created attachment 232745 [details]
Patch

Comment 3 Benjamin Poulain 2014-06-10 13:53:09 PDT

Created attachment 232812 [details]
Patch

Comment 4 Simon Fraser (smfr) 2014-06-10 18:19:31 PDT

Comment on attachment 232812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:1066
> +    CGFloat scaleFactor = contentZoomScale(self);
> +    [_contentView scaleFactorDidChange:scaleFactor];

Unrelated?

Comment 5 Tim Horton 2014-06-10 18:26:36 PDT

Comment on attachment 232812 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232812&action=review

> Source/WebCore/ChangeLog:8
> +        While udpating the style for animations, most of the time spent was pure calling overhead.

updating

Comment 6 Benjamin Poulain 2014-06-10 20:36:26 PDT

Committed r169790: <http://trac.webkit.org/changeset/169790>