|Summary:||Localization files with empty Language: block build with gettext 0.19|
|Product:||WebKit||Reporter:||Cédric D. <cedricde>|
|Component:||Text||Assignee:||Michael Catanzaro <mcatanzaro>|
|Severity:||Minor||CC:||berto, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson, piotrdrag|
|Version:||528+ (Nightly build)|
Description Cédric D. 2014-06-07 14:08:05 PDT
Created attachment 232670 [details] Patch correcting the localization files with empty "Language" Some localization files in Source/WebCore/platform/gtk/po/ have an empty value for tag "Language:". As a result an error occurs during build with msgfmt 0.19 because it now returns an error when flag "-c" is used. The attached patch corrects this issue. Thank you for your attention.
Comment 1 Cédric D. 2014-06-10 13:45:20 PDT
The behaviour changed again in gettext 0.19.1. Here is an extract from its NEWS file: * msgfmt now treats errors in the PO file header as non-fatal. Since 0.19 msgfmt started to abort on the fatal errors, but some translation systems are still not ready to supply valid headers.
Comment 2 Piotr Drąg 2016-04-16 16:22:18 PDT
The patch is out of date. Currently as, en_CA, gu, hu, id, ko, lv, pa, ru, and sl translations have missing or incorrect Language tags.
Comment 4 WebKit Commit Bot 2016-04-16 19:39:08 PDT
Comment on attachment 276568 [details] Patch Clearing flags on attachment: 276568 Committed r199637: <http://trac.webkit.org/changeset/199637>
Comment 5 WebKit Commit Bot 2016-04-16 19:39:12 PDT
All reviewed patches have been landed. Closing bug.