Bug 133598

Summary: [Mac] caption size is not update immediately when system preferences change
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, calvaris, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Updated patch. none

Description Eric Carlson 2014-06-06 19:09:06 PDT
Changing the system preference for caption size does not immediately update caption size.
Comment 1 Eric Carlson 2014-06-06 19:09:31 PDT
<rdar://problem/17039796>
Comment 2 Eric Carlson 2014-06-06 19:15:33 PDT
Created attachment 232644 [details]
Proposed patch.
Comment 3 Build Bot 2014-06-06 20:16:51 PDT
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6008604066840576

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 4 Build Bot 2014-06-06 20:16:57 PDT
Created attachment 232645 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-06-06 20:39:54 PDT
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6151001023184896

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 6 Build Bot 2014-06-06 20:40:00 PDT
Created attachment 232647 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-06-06 21:39:31 PDT
Comment on attachment 232644 [details]
Proposed patch.

Attachment 232644 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4624696884592640

New failing tests:
media/track/regions-webvtt/vtt-region-display.html
Comment 8 Build Bot 2014-06-06 21:39:36 PDT
Created attachment 232652 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Jer Noble 2014-06-09 10:44:45 PDT
Comment on attachment 232644 [details]
Proposed patch.

r=me, but you may want to look into the vtt test failure.  It may just need a rebaseline.
Comment 10 Eric Carlson 2014-06-09 11:00:15 PDT
Created attachment 232714 [details]
Updated patch.
Comment 11 WebKit Commit Bot 2014-06-09 12:39:58 PDT
Comment on attachment 232714 [details]
Updated patch.

Rejecting attachment 232714 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 232714, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/5780000942850048
Comment 12 Brent Fulgham 2014-06-09 13:32:44 PDT
Comment on attachment 232714 [details]
Updated patch.

r=me.
Comment 13 WebKit Commit Bot 2014-06-09 14:03:55 PDT
Comment on attachment 232714 [details]
Updated patch.

Clearing flags on attachment: 232714

Committed r169713: <http://trac.webkit.org/changeset/169713>
Comment 14 WebKit Commit Bot 2014-06-09 14:04:01 PDT
All reviewed patches have been landed.  Closing bug.