| Summary: | Should boost ChildProcesses on iOS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||
| Component: | WebKit2 | Assignee: | Gavin Barraclough <barraclough> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | Keywords: | InRadar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Gavin Barraclough
2014-06-06 14:27:02 PDT
Created attachment 232628 [details]
Fix
rdar 17199785 Comment on attachment 232628 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=232628&action=review > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:191 > +#if PLATFORM(IOS) > + // On iOS, leak a boost onto all child processes > + bool leakBoost = true; > +#elif ENABLE(NETWORK_PROCESS) > + // On Mac, leak a boost onto the NetworkProcess. > + bool leakBoost = launchOptions.processType == ProcessLauncher::NetworkProcess; > +#else > + bool leakBoost = false; > +#endif Please move this to a separate function, something like static bool shouldLeakBoost(const LaunchOptions&); Transmitting file data .. Committed revision 169663. Transmitting file data .. Committed revision 169663. |