Summary: | ASSERTION FAILED: is8Bit() at StringImpl::characters8() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | JavaScriptCore | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ap, commit-queue, ggaren, kling, mark.lam | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
zalan
2014-06-06 06:55:53 PDT
I can't seem to reproduce this :| Could you save all the tabs in a bookmark folder the next time it happens and pass me that bookmark? I wonder if this could be related to <rdar://problem/14296167>; I don't see how we could end up with a rope string that thinks the rope is 8-bit clean, but has an individual 16-bit fiber inside.. I also see this from time to time, and can never reproduce, not even when reloading the same page. Created attachment 236775 [details]
Patch
Comment on attachment 236775 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236775&action=review > Source/JavaScriptCore/runtime/JSString.h:204 > + mutable unsigned m_flags; I think it’s a little peculiar to make this change, but I think what makes it clear that it’s right is that this is closely associated with m_value and the two need to match. Too bad m_length is between this and m_value, making it really hard to see that connection. *** Bug 135714 has been marked as a duplicate of this bug. *** Comment on attachment 236775 [details] Patch Clearing flags on attachment: 236775 Committed r172727: <http://trac.webkit.org/changeset/172727> All reviewed patches have been landed. Closing bug. |