Bug 133548

Summary: Replace %pure_parser directive as it's deprecated
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED LATER    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review-

Description Sergio Villar Senin 2014-06-05 09:07:54 PDT
Replace %pure_parser directive as it's deprecated
Comment 1 Sergio Villar Senin 2014-06-05 09:09:04 PDT
Created attachment 232555 [details]
Patch
Comment 2 Sergio Villar Senin 2014-06-05 09:14:53 PDT
This is the warning I'm seeing when building:

warning: deprecated directive, use ‘%pure-parser’ [-Wdeprecated]

BTW this directive was added in Bison 2.6 AFAIK. Not sure all the ports require at least that version
Comment 3 Alexey Proskuryakov 2014-06-05 09:43:42 PDT
Comment on attachment 232555 [details]
Patch

This patch breaks Mac Mountain Lion build:

./CSSGrammar.y:62.9-16: syntax error, unexpected identifier, expecting string
Died at WebCore/css/makegrammar.pl line 84.
Comment 4 Sergio Villar Senin 2014-06-05 09:56:04 PDT
(In reply to comment #3)
> (From update of attachment 232555 [details])
> This patch breaks Mac Mountain Lion build:
> 
> ./CSSGrammar.y:62.9-16: syntax error, unexpected identifier, expecting string
> Died at WebCore/css/makegrammar.pl line 84.

ap, do you know which Bison version is Mountain Lion using?
Comment 5 Sergio Villar Senin 2015-06-02 23:48:30 PDT
Let's forget about this.