Bug 133525

Summary:

DFG::Safepoint::begin() should set m_didCallBegin before releasing the rightToRun lock, because otherwise, Safepoint::checkLivenessAndVisitChildren() may assert due to a race

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

atrick, barraclough, ggaren, juergen, mark.lam, mhahnenberg, msaboff, nrotem, oliver, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	oliver: review+

Description Filip Pizlo 2014-06-04 14:18:21 PDT

Patch forthcoming.

<rdar://problem/16790296>

Comment 1 Filip Pizlo 2014-06-04 14:19:38 PDT

Created attachment 232500 [details]
the patch

Comment 2 Filip Pizlo 2014-06-04 14:29:52 PDT

Landed in http://trac.webkit.org/changeset/169595