Bug 133519 – [GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Carlos Alberto Lopez Perez]

The following layout test added on r169427 <http://trac.webkit.org/r169427> is failing on GTK since it was added.

accessibility/table-fallback-roles-expose-element-attributes.html

The diff is the following:

--- /home/clopez/webkit/webkit/layout-test-results/accessibility/table-fallback-roles-expose-element-attributes-expected.txt
+++ /home/clopez/webkit/webkit/layout-test-results/accessibility/table-fallback-roles-expose-element-attributes-actual.txt
@@ -6,11 +6,11 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-cellChild: AXRole: AXStaticText, AXValue: item1
+cellChild: , 
 
-cellChild: AXRole: AXStaticText, AXValue: item1
+cellChild: , 
 
-cellChild: AXRole: AXStaticText, AXValue: item1
+cellChild: , 
 
 PASS successfullyParsed is true

[Mario Sanchez Prada]

The problem here is that we don't expose the text in a cell as a child element for ATK, so that's why we can't anything printed when we navigate down to that level.

In other words, in the Mac the hiearchy is like this

  Grid
    |--Cell
    |    |--text
    |--Cell
    |    |--text
   ...  ...

In ATK, however, it's like this:

  Grid
    |--Cell
    |--Cell
   ...  ...

...and you get the text in the cell by quering the AX object for that cell (which implements AtkText).

Because of that reason, the following code can't output anything reasonable for ATK:

  if (window.accessibilityController) {
      for (var k = 1; k < 4; k++) {
         var grid = accessibilityController.accessibleElementById("grid" + k);
         var cellChild = grid.cellForColumnAndRow(0, 0).childAtIndex(0);
         debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n");
      }
  }

I think an improvement could be to do something like this:

  if (window.accessibilityController) {
      for (var k = 1; k < 4; k++) {
          var grid = accessibilityController.accessibleElementById("grid" + k);
          var cell = grid.cellForColumnAndRow(0, 0);
          debug("cell: " + cell.role + ", " + cell.stringValue + "\n");
          if (accessibilityController.platformName != "atk") {
              var cellChild = cell.childAtIndex(0);
              debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n");
          }
      }
  }

...and then update the expectations accordingly (probably with the help of the EWS, to know what the Mac would print there)

[Mario Sanchez Prada]

Created attachment 232535 [details]
Path proposal

Attaching patch proposal but not asking for review yet since I'm mostly interested on seeing what the Mac EWS bots have to say about my guessed output

[Build Bot]

Comment on attachment 232535 [details]
Path proposal

Attachment 232535 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4519381602140160

New failing tests:
accessibility/table-fallback-roles-expose-element-attributes.html

[Build Bot]

Created attachment 232538 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Mario Sanchez Prada]

Created attachment 232539 [details]
Path proposal

Now making the Mac bots happy

[Mario Sanchez Prada]

Created attachment 232613 [details]
Patch proposal

Forgot to remove the failure test expectation before, so this should be the final patch

Please review, thanks

[chris fleizach]

Comment on attachment 232613 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=232613&action=review

> LayoutTests/ChangeLog:12
> +        Updated text to print information of cells fro every platform but

cells fro -> cells from

[Mario Sanchez Prada]

(In reply to comment #7)
> (From update of attachment 232613 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232613&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        Updated text to print information of cells fro every platform but
> 
> cells fro -> cells from

Will change before landing.

Thanks

[Mario Sanchez Prada]

Committed r169646: <http://trac.webkit.org/changeset/169646>

[Michal Pakula vel Rutka]

*** Bug 133508 has been marked as a duplicate of this bug. ***