Summary: | [GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | a.badowski, aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-06-04 11:18:09 PDT
The problem here is that we don't expose the text in a cell as a child element for ATK, so that's why we can't anything printed when we navigate down to that level. In other words, in the Mac the hiearchy is like this Grid |--Cell | |--text |--Cell | |--text ... ... In ATK, however, it's like this: Grid |--Cell |--Cell ... ... ...and you get the text in the cell by quering the AX object for that cell (which implements AtkText). Because of that reason, the following code can't output anything reasonable for ATK: if (window.accessibilityController) { for (var k = 1; k < 4; k++) { var grid = accessibilityController.accessibleElementById("grid" + k); var cellChild = grid.cellForColumnAndRow(0, 0).childAtIndex(0); debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n"); } } I think an improvement could be to do something like this: if (window.accessibilityController) { for (var k = 1; k < 4; k++) { var grid = accessibilityController.accessibleElementById("grid" + k); var cell = grid.cellForColumnAndRow(0, 0); debug("cell: " + cell.role + ", " + cell.stringValue + "\n"); if (accessibilityController.platformName != "atk") { var cellChild = cell.childAtIndex(0); debug("cellChild: " + cellChild.role + ", " + cellChild.stringValue + "\n"); } } } ...and then update the expectations accordingly (probably with the help of the EWS, to know what the Mac would print there) Created attachment 232535 [details]
Path proposal
Attaching patch proposal but not asking for review yet since I'm mostly interested on seeing what the Mac EWS bots have to say about my guessed output
Comment on attachment 232535 [details] Path proposal Attachment 232535 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4519381602140160 New failing tests: accessibility/table-fallback-roles-expose-element-attributes.html Created attachment 232538 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 232539 [details]
Path proposal
Now making the Mac bots happy
Created attachment 232613 [details]
Patch proposal
Forgot to remove the failure test expectation before, so this should be the final patch
Please review, thanks
Comment on attachment 232613 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=232613&action=review > LayoutTests/ChangeLog:12 > + Updated text to print information of cells fro every platform but cells fro -> cells from (In reply to comment #7) > (From update of attachment 232613 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232613&action=review > > > LayoutTests/ChangeLog:12 > > + Updated text to print information of cells fro every platform but > > cells fro -> cells from Will change before landing. Thanks Committed r169646: <http://trac.webkit.org/changeset/169646> *** Bug 133508 has been marked as a duplicate of this bug. *** |