Summary: | [GTK] 4 of the css3/viewport-percentage-lengths/viewport-percentage-lengths-.*.html tests time out | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abucur, bjonesbe, cfleizach, commit-queue, darin, glenn, mario, mihnea, mrobinson | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 133993 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2014-06-04 10:47:25 PDT
I'm betting those are timing out because the onresize event doesn't fire in DRT/WTR on the GTK+ port. Darin fixed DRT/WTR for the Mac port in Bug 133351 when he changed the tests to use the onresize event. He made an attempt to fix the other ports as well, but it is possible that fix didn't work for the GTK port. Hopefully it's an easy fix. Created attachment 233235 [details]
Patch
Comment on attachment 233235 [details]
Patch
Awesome!
Comment on attachment 233235 [details] Patch Clearing flags on attachment: 233235 Committed r170058: <http://trac.webkit.org/changeset/170058> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 133993 (In reply to comment #6) > Re-opened since this is blocked by bug 133993 Ups! Forgot to update the resolution for the unit tests of Xvfb. I will upload an updated patch. Created attachment 233261 [details]
Patch
Comment on attachment 233261 [details] Patch Clearing flags on attachment: 233261 Committed r170078: <http://trac.webkit.org/changeset/170078> All reviewed patches have been landed. Closing bug. |