| Summary: | [MediaStream] MediaStream.addTrack should not check for tracks ended state. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kiran <kiran.guduru> | ||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, hta, jer.noble, lucas.de.marchi, philipj, sergio, tommyw | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kiran
2014-06-04 06:01:49 PDT
Created attachment 232475 [details]
MediaStream.addTrack should not check for tracks ended state.
MediaStream.addTrack should not check for tracks ended state.
Created attachment 232476 [details]
MediaStream.addTrack should not check for tracks ended state.
Added test files.
Comment on attachment 232476 [details] MediaStream.addTrack should not check for tracks ended state. View in context: https://bugs.webkit.org/attachment.cgi?id=232476&action=review If you address the comments, fill in the "Reviewed by" in each ChangeLog, and upload the new patch WITHOUT orphaning the old version, you don't need another review and any reviewer will mark it cq+. > Source/WebCore/ChangeLog:14 > + (WebCore::MediaStreamPrivate::addTrack): Nit: I think it is helpful to have a comment about what changed. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:1 > +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> Nit: you should use an HTML5 doctype here: "<!DOCTYPE html>" > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:7 > + > + Nit: you have an extra blank line. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:10 > + Ditto. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:41 > + Ditto. > LayoutTests/fast/mediastream/MediaStream-add-ended-tracks.html:50 > + Ditto. Created attachment 232519 [details]
MediaStream.addTrack should not check for tracks ended state.
Added comment line and removed blank spaces as per the review comments.
Comment on attachment 232519 [details] MediaStream.addTrack should not check for tracks ended state. Clearing flags on attachment: 232519 Committed r169611: <http://trac.webkit.org/changeset/169611> Patches landed, so closing the bug. |