Bug 133502

Summary: Scheme of content utils should be compared in an ASCII case-insensitive manner
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, bunhere, cdumez, commit-queue, darin, gyuyoung.kim, rniwa, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
Patch
none
Patch
none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Patch
none
Patch for landing none

Gyuyoung Kim
Reported 2014-06-03 22:18:26 PDT
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=133296#c19, whitelist needs to have case-sensitive. "A scheme, such as mailto or web+auth. The scheme must be compared in an ASCII case-insensitive manner by user agents for the purposes of comparing with the scheme part of URLs that they consider against the list of registered handlers."
Attachments
WIP (1.63 KB, patch)
2014-06-04 17:51 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (11.52 KB, patch)
2014-06-05 07:23 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (11.51 KB, patch)
2014-06-05 07:25 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (501.42 KB, application/zip)
2014-06-05 08:51 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (601.92 KB, application/zip)
2014-06-05 09:02 PDT, Build Bot 		no flags
Details
Patch (11.44 KB, patch)
2014-06-05 11:56 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch for landing (11.47 KB, patch)
2014-06-06 17:52 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2014-06-04 17:51:54 PDT
Created attachment 232514 [details] WIP
Gyuyoung Kim
Comment 2 2014-06-05 07:23:02 PDT
Created attachment 232545 [details] Patch
Gyuyoung Kim
Comment 3 2014-06-05 07:25:21 PDT
Created attachment 232546 [details] Patch
Build Bot
Comment 4 2014-06-05 08:51:24 PDT
Comment on attachment 232546 [details] Patch Attachment 232546 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6645613751959552 New failing tests: fast/dom/NavigatorContentUtils/unregister-protocol-handler.html
Build Bot
Comment 5 2014-06-05 08:51:30 PDT
Created attachment 232552 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 6 2014-06-05 09:02:37 PDT
Comment on attachment 232546 [details] Patch Attachment 232546 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6215440565010432 New failing tests: fast/dom/NavigatorContentUtils/unregister-protocol-handler.html
Build Bot
Comment 7 2014-06-05 09:02:45 PDT
Created attachment 232554 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Gyuyoung Kim
Comment 8 2014-06-05 11:56:21 PDT
Created attachment 232572 [details] Patch
Gyuyoung Kim
Comment 9 2014-06-05 20:06:23 PDT
CC'ing Darin
Darin Adler
Comment 10 2014-06-06 09:18:06 PDT
Comment on attachment 232572 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232572&action=review > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:101 > + No need to add this blank line.
Gyuyoung Kim
Comment 11 2014-06-06 17:52:54 PDT
Created attachment 232639 [details] Patch for landing
WebKit Commit Bot
Comment 12 2014-06-06 18:29:52 PDT
Comment on attachment 232639 [details] Patch for landing Clearing flags on attachment: 232639 Committed r169670: <http://trac.webkit.org/changeset/169670>
WebKit Commit Bot
Comment 13 2014-06-06 18:29:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.