Bug 133502

Summary:

Scheme of content utils should be compared in an ASCII case-insensitive manner

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, darin, gyuyoung.kim, rniwa, sergio

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Patch	none
Patch for landing	none

Description Gyuyoung Kim 2014-06-03 22:18:26 PDT

As mentioned in https://bugs.webkit.org/show_bug.cgi?id=133296#c19, whitelist needs to have case-sensitive.

"A scheme, such as mailto or web+auth. The scheme must be compared in an ASCII case-insensitive manner by user agents for the purposes of comparing with the scheme part of URLs that they consider against the list of registered handlers."

Comment 1 Gyuyoung Kim 2014-06-04 17:51:54 PDT

Created attachment 232514 [details]
WIP

Comment 2 Gyuyoung Kim 2014-06-05 07:23:02 PDT

Created attachment 232545 [details]
Patch

Comment 3 Gyuyoung Kim 2014-06-05 07:25:21 PDT

Created attachment 232546 [details]
Patch

Comment 4 Build Bot 2014-06-05 08:51:24 PDT

Comment on attachment 232546 [details]
Patch

Attachment 232546 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6645613751959552

New failing tests:
fast/dom/NavigatorContentUtils/unregister-protocol-handler.html

Comment 5 Build Bot 2014-06-05 08:51:30 PDT

Created attachment 232552 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 6 Build Bot 2014-06-05 09:02:37 PDT

Comment on attachment 232546 [details]
Patch

Attachment 232546 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6215440565010432

New failing tests:
fast/dom/NavigatorContentUtils/unregister-protocol-handler.html

Comment 7 Build Bot 2014-06-05 09:02:45 PDT

Created attachment 232554 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 8 Gyuyoung Kim 2014-06-05 11:56:21 PDT

Created attachment 232572 [details]
Patch

Comment 9 Gyuyoung Kim 2014-06-05 20:06:23 PDT

CC'ing Darin

Comment 10 Darin Adler 2014-06-06 09:18:06 PDT

Comment on attachment 232572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232572&action=review

> Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:101
> +

No need to add this blank line.

Comment 11 Gyuyoung Kim 2014-06-06 17:52:54 PDT

Created attachment 232639 [details]
Patch for landing

Comment 12 WebKit Commit Bot 2014-06-06 18:29:52 PDT

Comment on attachment 232639 [details]
Patch for landing

Clearing flags on attachment: 232639

Committed r169670: <http://trac.webkit.org/changeset/169670>

Comment 13 WebKit Commit Bot 2014-06-06 18:29:59 PDT

All reviewed patches have been landed.  Closing bug.