Summary: | Regression(r169547): Crash in WebCore::styleForFirstLetter() while loading http://thenextweb.com/apple/2014/02/21/apple-confirms-acquired-testflight-creator-burstly/ | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||
Component: | CSS | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, commit-queue, esprehn+autocc, georgij.michaliutin, glenn, gyuyoung.kim, macpherson, menard, ysuzuki | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
URL: | http://thenextweb.com/apple/2014/02/21/apple-confirms-acquired-testflight-creator-burstly/ | ||||||
Attachments: |
|
Description
zalan
2014-06-03 20:54:06 PDT
Ok, I have an idea of what is going on. Some selector must have ::first-letter, but does not actually match. When matching the rightmost fragment, we set the FIRST_LETTER flag on the style. When generating the blocks for layout, RenderBlock find that one block has FIRST_LETTER, and try to get its style. Since the selector does not actually match, the style never resolve and the code continue with a null style. Created attachment 232501 [details]
Patch
Comment on attachment 232501 [details] Patch Clearing flags on attachment: 232501 Committed r169599: <http://trac.webkit.org/changeset/169599> All reviewed patches have been landed. Closing bug. |