Bug 13350

Summary:

Build Ahem into DumpRenderTree

Product:

WebKit

Reporter:

mitz

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

ddkilzer

Priority:

Version:

523.x (Safari 3)

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Load and activate Ahem in DumpRenderTree	darin: review+
Load and activate Ahem in DumpRenderTree	darin: review+

mitz

Reported 2007-04-14 10:07:38 PDT

DumpRenderTree can load and activate Ahem locally so that users don't have to download and activate it globally.

Attachments
Load and activate Ahem in DumpRenderTree (6.57 KB, patch) 2007-04-14 10:09 PDT, mitz	darin: review+	Details Formatted Diff Diff
Load and activate Ahem in DumpRenderTree (9.93 KB, patch) 2007-04-19 09:12 PDT, mitz	darin: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2007-04-14 10:09:19 PDT

Created attachment 14033 [details] Load and activate Ahem in DumpRenderTree I couldn't figure out how to make the linking phase depend on AHEM____.TTF.

Darin Adler

Comment 2 2007-04-15 14:15:24 PDT

Comment on attachment 14033 [details] Load and activate Ahem in DumpRenderTree +static void activateAhemFont() Should be (void) since this is ObjC, not C++. Some people will still want to install Ahem so they can inspect the results of tests by hand. We might need to mention that. r=me

mitz

Comment 3 2007-04-19 09:12:08 PDT

Created attachment 14090 [details] Load and activate Ahem in DumpRenderTree Changed () to (void) and added information about Ahem to the page about writing tests.

Mark Rowe (bdash)

Comment 4 2007-04-21 01:40:08 PDT

Landed in r20994.

Note You need to log in before you can comment on or make changes to this bug.