Bug 133491 – Subpixel rendering: border-radius painting falls back to rectangle when the snapped rounded rect becomes non-renderable.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

ssia

[alan]

Created attachment 232442 [details]
Test reduction

[alan]

<rdar://problem/17078906>

[alan]

Created attachment 232444 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 232444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review

> Source/WebCore/platform/graphics/RoundedRect.cpp:250
> +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));

Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.

[alan]

Created attachment 232556 [details]
Patch

[alan]

(In reply to comment #4)
> (From update of attachment 232444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review
> 
> > Source/WebCore/platform/graphics/RoundedRect.cpp:250
> > +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));
> 
> Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
We do have it! Fixed.

[WebKit Commit Bot]

Comment on attachment 232556 [details]
Patch

Clearing flags on attachment: 232556

Committed r169620: <http://trac.webkit.org/changeset/169620>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.