Bug 133491

Summary: Subpixel rendering: border-radius painting falls back to rectangle when the snapped rounded rect becomes non-renderable.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser
Priority: P2 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test reduction
none
Patch
none
Patch none

Description zalan 2014-06-03 15:01:25 PDT 
ssia
Comment 1 zalan 2014-06-03 15:01:51 PDT 
Created attachment 232442 [details]
Test reduction
Comment 2 zalan 2014-06-03 15:03:10 PDT 
<rdar://problem/17078906>
Comment 3 zalan 2014-06-03 15:30:50 PDT 
Created attachment 232444 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-06-04 16:04:18 PDT 
Comment on attachment 232444 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review

> Source/WebCore/platform/graphics/RoundedRect.cpp:250
> +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));

Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
Comment 5 zalan 2014-06-05 09:11:51 PDT 
Created attachment 232556 [details]
Patch
Comment 6 zalan 2014-06-05 09:18:21 PDT 
(In reply to comment #4)
> (From update of attachment 232444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232444&action=review
> 
> > Source/WebCore/platform/graphics/RoundedRect.cpp:250
> > +        adjustedRadii.setTopLeft(LayoutSize(adjustedRadii.topLeft().width() / horizonalRatio, adjustedRadii.topLeft().height() / verticalRatio));
> 
> Would be cleaner if we had LayoutSize::scale(x, y) and you scaled by 1/ratio.
We do have it! Fixed.
Comment 7 WebKit Commit Bot 2014-06-05 11:19:10 PDT 
Comment on attachment 232556 [details]
Patch

Clearing flags on attachment: 232556

Committed r169620: <http://trac.webkit.org/changeset/169620>
Comment 8 WebKit Commit Bot 2014-06-05 11:19:14 PDT 
All reviewed patches have been landed.  Closing bug.