Bug 133488

Summary:

Subpixel rendering: Buttons in default media controls shift vertically when controls fade in or out.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser, WebkitBugTracker

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2	none
Patch	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Patch	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Patch	none

Description zalan 2014-06-03 13:49:54 PDT

1. Navigate to <http://movies.apple.com/movies/us/apple/ipoditunes/2007/touch/ads/apple_ipodtouch_touch_r640-9cie.mov>
2. As the video is playing, move the mouse pointer over the video and off the video to cause the controls to fade in, then out

As soon as the controls start fading out, the buttons shift vertically. As soon as they finish fading in, a similar shift occurs.

Comment 1 zalan 2014-06-03 13:50:21 PDT

<rdar://problem/16272404>

Comment 2 zalan 2014-06-03 14:17:26 PDT

Created attachment 232439 [details]
Patch

Comment 3 Simon Fraser (smfr) 2014-06-03 14:26:37 PDT

Comment on attachment 232439 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232439&action=review

> LayoutTests/ChangeLog:13
> +        * css3/filters/filter-is-on-subpixel-position-on-non-retina-expected.html: Added.
> +        * css3/filters/filter-is-on-subpixel-position-on-non-retina.html: Added.

I think you can remove "on non retina" from the filenames.

Comment 4 zalan 2014-06-03 14:41:02 PDT

Created attachment 232440 [details]
Patch

Comment 5 zalan 2014-06-03 14:41:16 PDT

Comment on attachment 232440 [details]
Patch

EWS

Comment 6 Build Bot 2014-06-03 16:05:07 PDT

Comment on attachment 232440 [details]
Patch

Attachment 232440 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6506094759247872

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
fast/regions/inline-block-overflow.html

Comment 7 Build Bot 2014-06-03 16:05:11 PDT

Created attachment 232446 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 8 Build Bot 2014-06-03 17:11:40 PDT

Comment on attachment 232440 [details]
Patch

Attachment 232440 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5827822786445312

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
fast/regions/inline-block-overflow.html

Comment 9 Build Bot 2014-06-03 17:11:43 PDT

Created attachment 232452 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 10 Build Bot 2014-06-03 21:45:59 PDT

Comment on attachment 232440 [details]
Patch

Attachment 232440 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4933975667638272

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
fast/regions/inline-block-overflow.html

Comment 11 Build Bot 2014-06-03 21:46:02 PDT

Created attachment 232464 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 12 Build Bot 2014-06-04 05:06:29 PDT

Comment on attachment 232440 [details]
Patch

Attachment 232440 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4903226923024384

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
fast/regions/inline-block-overflow.html

Comment 13 Build Bot 2014-06-04 05:06:33 PDT

Created attachment 232473 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 14 zalan 2014-06-04 13:44:16 PDT

Created attachment 232497 [details]
Patch

Comment 15 zalan 2014-06-04 13:44:29 PDT

Comment on attachment 232497 [details]
Patch

EWS

Comment 16 Build Bot 2014-06-04 15:07:43 PDT

Comment on attachment 232497 [details]
Patch

Attachment 232497 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6567992754176000

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
fast/regions/inline-block-overflow.html

Comment 17 Build Bot 2014-06-04 15:07:47 PDT

Created attachment 232505 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 18 zalan 2014-06-04 15:19:50 PDT

Created attachment 232506 [details]
Patch

Comment 19 zalan 2014-06-04 15:20:42 PDT

Comment on attachment 232506 [details]
Patch

missing -expected changes.
EWS again.

Comment 20 Build Bot 2014-06-04 16:53:58 PDT

Comment on attachment 232506 [details]
Patch

Attachment 232506 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5177024645693440

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html

Comment 21 Build Bot 2014-06-04 16:54:02 PDT

Created attachment 232510 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 22 Build Bot 2014-06-04 17:43:45 PDT

Comment on attachment 232506 [details]
Patch

Attachment 232506 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5923300983177216

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html

Comment 23 Build Bot 2014-06-04 17:43:49 PDT

Created attachment 232513 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

Comment 24 Build Bot 2014-06-04 21:31:12 PDT

Comment on attachment 232506 [details]
Patch

Attachment 232506 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6483570877005824

New failing tests:
fast/regions/inline-block-inside-anonymous-overflow.html
sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.3_encodeURI/S15.1.3.3_A1.1_T1.html

Comment 25 Build Bot 2014-06-04 21:31:16 PDT

Created attachment 232522 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 26 zalan 2014-06-05 06:52:36 PDT

Created attachment 232543 [details]
Patch

Comment 27 zalan 2014-06-05 06:52:50 PDT

Comment on attachment 232543 [details]
Patch

EWS

Comment 28 WebKit Commit Bot 2014-06-05 09:00:07 PDT

Comment on attachment 232543 [details]
Patch

Clearing flags on attachment: 232543

Committed r169615: <http://trac.webkit.org/changeset/169615>

Comment 29 WebKit Commit Bot 2014-06-05 09:00:13 PDT

All reviewed patches have been landed.  Closing bug.