Bug 133479

Summary:

[ATK] accessibility/textarea-selected-text-range.html is failing

Product:

WebKit

Reporter:

Mario Sanchez Prada <mario>

Component:

Accessibility

Assignee:

Mario Sanchez Prada <mario>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

Linux

Attachments:

Description	Flags
Patch proposal	none

Description Mario Sanchez Prada 2014-06-03 08:48:37 PDT

This test is failing after r169483 because now atk_text_set_caret_offset() is use in AccessibilityUIElement::setSelectedTextRange() when length is zero, proving that the implementation of atk_text_set_caret_offset() is not correct (it should match atk_text_set_selection() for zero-length selections)

Patch coming soon...

Comment 1 Mario Sanchez Prada 2014-06-03 09:11:11 PDT

Created attachment 232428 [details]
Patch proposal

There was indeed a problem in the implementation of atk_text_set_caret_offset, which was not controlling boundaries properly as atk_text_set_selection does. This patch just implements one function in terms of the other. Please review, thanks

Comment 2 WebKit Commit Bot 2014-06-03 14:38:30 PDT

Comment on attachment 232428 [details]
Patch proposal

Clearing flags on attachment: 232428

Committed r169572: <http://trac.webkit.org/changeset/169572>

Comment 3 WebKit Commit Bot 2014-06-03 14:38:33 PDT

All reviewed patches have been landed.  Closing bug.