Summary: | [EFL]Build error in WebKit2/Shared/Downloads/soup/DownloadSoup.cpp | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tanay <tanay.c> | ||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, commit-queue, ossy, tanay.c | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Tanay
2014-06-02 23:24:10 PDT
gcc 4.7 I guess, we need a explicit cast (or constructor) to workaround it (In reply to comment #1) > gcc 4.7 I guess, we need a explicit cast (or constructor) to workaround it Do we still support GCC 4.7 ? Created attachment 232470 [details]
Patch
The EFL build bots are using 4.8.1 version. However, I notice this error when compiling with GCC 4.7.3. Comment on attachment 232470 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232470&action=review > Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190 > - m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", std::bind(&DownloadClient::handleResponse, this)); > + m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", static_cast<std::function<void()>>(std::bind(&DownloadClient::handleResponse, this))); I think you can use the function constructor instead of a static cast, something like std::function<void()>(std::bind(&DownloadClient::handleResponse, this)). I think it's cleaner. (In reply to comment #5) > (From update of attachment 232470 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232470&action=review > > > Source/WebKit2/Shared/Downloads/soup/DownloadSoup.cpp:190 > > - m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", std::bind(&DownloadClient::handleResponse, this)); > > + m_handleResponseLater.schedule("[WebKit] DownloadHandleResponseLater", static_cast<std::function<void()>>(std::bind(&DownloadClient::handleResponse, this))); > > I think you can use the function constructor instead of a static cast, something like std::function<void()>(std::bind(&DownloadClient::handleResponse, this)). I think it's cleaner. Sure, uploading another patch. Created attachment 232471 [details]
Patch
Comment on attachment 232471 [details]
Patch
Thanks
Comment on attachment 232471 [details] Patch Clearing flags on attachment: 232471 Committed r169612: <http://trac.webkit.org/changeset/169612> All reviewed patches have been landed. Closing bug. |