Summary: | REGRESSION(169440): Repro crash when playing a video with captions | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, gyuyoung.kim, philipj, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Brent Fulgham
2014-06-02 13:59:05 PDT
Created attachment 232398 [details]
Patch
Created attachment 232595 [details]
Patch
Comment on attachment 232595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232595&action=review > Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:405 > + LOG(Media, "InbandTextTrackPrivateAVF::processCue(%p) - found an extension cue for time = %.2f, position = %.2f, line = %.2f", this, arrivingCue->startTime(), arrivingCue->position(), arrivingCue->line()); Won't this log about every cue regardless of whether or not it extends a cue? Comment on attachment 232595 [details] Patch Attachment 232595 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6501615309684736 New failing tests: media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html Created attachment 232604 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 232595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232595&action=review >> Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:405 >> + LOG(Media, "InbandTextTrackPrivateAVF::processCue(%p) - found an extension cue for time = %.2f, position = %.2f, line = %.2f", this, arrivingCue->startTime(), arrivingCue->position(), arrivingCue->line()); > > Won't this log about every cue regardless of whether or not it extends a cue? Whoops! Yes, I'll fix that. Committed r169647: <http://trac.webkit.org/changeset/169647> |