[MSE][Mac] Media does not generate 'ended' event when playing to duration.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[MSE][Mac] Media does not generate 'ended' event when playing to duration.

[Jer Noble]

Created attachment 232387 [details]
Patch

[Eric Carlson]

Comment on attachment 232387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232387&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:325
> +    if (currentMediaTime() >= m_mediaSourcePrivate->duration()) {
> +        effectiveRateChanged();
> +        return;
> +    }

Do you want to post a rate changed notification if this is called when the rate is non-zero?

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:606
> +    if (!m_mediaSourcePrivate)
> +        return;
> +
> +    if (m_durationObserver)
> +        [m_synchronizer removeTimeObserver:m_durationObserver.get()];

Is there any reason to keep the observer for the (potentially invalid) duration if m_mediaSourcePrivate is NULL?

[Jer Noble]

(In reply to comment #2)
> (From update of attachment 232387 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232387&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:325
> > +    if (currentMediaTime() >= m_mediaSourcePrivate->duration()) {
> > +        effectiveRateChanged();
> > +        return;
> > +    }
> 
> Do you want to post a rate changed notification if this is called when the rate is non-zero?

Well, it doesn't hurt anything, but I guess the explicit notification isn't necessary.

> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:606
> > +    if (!m_mediaSourcePrivate)
> > +        return;
> > +
> > +    if (m_durationObserver)
> > +        [m_synchronizer removeTimeObserver:m_durationObserver.get()];
> 
> Is there any reason to keep the observer for the (potentially invalid) duration if m_mediaSourcePrivate is NULL?

Nope, I'll switch the order of these stanzas.

[Jer Noble]

Created attachment 232391 [details]
Patch for landing

[Jer Noble]

Committed r169536 <http://trac.webkit.org/changeset/169536>.

[Jer Noble]

GTK Build fix landed in r169537.