Bug 133433

Summary: DYEBench: CSS parser warning at line 106 of base.css
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, mjs, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug
none
Removed them entirely
none
Updated the last rule. none

Description Ryosuke Niwa 2014-06-01 00:06:04 PDT 
We're hitting a CSS parser warning at line 106 of every base.css in TodoMVC benchmarks because the value contains a colon.
Thankfully, newer versions (8+) of IE supports -ms-filter syntax which can wrap the CSS value in double quotations so use that instead.
Comment 1 Ryosuke Niwa 2014-06-01 00:09:53 PDT 
Created attachment 232337 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2014-06-01 00:15:08 PDT 
Created attachment 232338 [details]
Removed them entirely
Comment 3 Ryosuke Niwa 2014-06-01 00:16:10 PDT 
Created attachment 232339 [details]
Updated the last rule.
Comment 4 Maciej Stachowiak 2014-06-01 02:39:49 PDT 
Comment on attachment 232339 [details]
Updated the last rule.

r=me
Comment 5 WebKit Commit Bot 2014-06-01 06:45:02 PDT 
Comment on attachment 232339 [details]
Updated the last rule.

Clearing flags on attachment: 232339

Committed r169514: <http://trac.webkit.org/changeset/169514>
Comment 6 WebKit Commit Bot 2014-06-01 06:45:05 PDT 
All reviewed patches have been landed.  Closing bug.