Bug 133433

Summary:

DYEBench: CSS parser warning at line 106 of base.css

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Tools / Tests

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, darin, mjs, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none
Removed them entirely	none
Updated the last rule.	none

Ryosuke Niwa

Reported 2014-06-01 00:06:04 PDT

We're hitting a CSS parser warning at line 106 of every base.css in TodoMVC benchmarks because the value contains a colon. Thankfully, newer versions (8+) of IE supports -ms-filter syntax which can wrap the CSS value in double quotations so use that instead.

Attachments
Fixes the bug (9.96 KB, patch) 2014-06-01 00:09 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Removed them entirely (9.24 KB, patch) 2014-06-01 00:15 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Updated the last rule. (9.12 KB, patch) 2014-06-01 00:16 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2014-06-01 00:09:53 PDT

Created attachment 232337 [details] Fixes the bug

Ryosuke Niwa

Comment 2 2014-06-01 00:15:08 PDT

Created attachment 232338 [details] Removed them entirely

Ryosuke Niwa

Comment 3 2014-06-01 00:16:10 PDT

Created attachment 232339 [details] Updated the last rule.

Maciej Stachowiak

Comment 4 2014-06-01 02:39:49 PDT

Comment on attachment 232339 [details] Updated the last rule. r=me

WebKit Commit Bot

Comment 5 2014-06-01 06:45:02 PDT

Comment on attachment 232339 [details] Updated the last rule. Clearing flags on attachment: 232339 Committed r169514: <http://trac.webkit.org/changeset/169514>

WebKit Commit Bot

Comment 6 2014-06-01 06:45:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.