Bug 133429

Summary:

Subpixel rendering: Selection gap produces a pixel line overlap on inline boxes.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser

Priority:

Keywords:

InRadar, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test reduction	none
Patch	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
Patch	none

alan

Reported 2014-05-31 19:42:09 PDT

when a simple inline text is selected, there is an overlapping one device pixel line next to the text.

Attachments
Test reduction (307 bytes, text/html) 2014-05-31 19:42 PDT, alan	no flags	Details
Patch (8.00 KB, patch) 2014-05-31 20:09 PDT, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (507.47 KB, application/zip) 2014-05-31 22:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (479.74 KB, application/zip) 2014-06-01 01:12 PDT, Build Bot	no flags	Details
Patch (9.31 KB, patch) 2014-06-01 07:40 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2014-05-31 19:42:33 PDT

Created attachment 232330 [details] Test reduction

alan

Comment 2 2014-05-31 19:43:02 PDT

<rdar://problem/17012527>

alan

Comment 3 2014-05-31 20:09:41 PDT

Created attachment 232332 [details] Patch

Build Bot

Comment 4 2014-05-31 22:37:04 PDT

Comment on attachment 232332 [details] Patch Attachment 232332 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5538202672693248 New failing tests: fast/inline/hidpi-selection-gap-overlaps-inline-selection.html fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html

Build Bot

Comment 5 2014-05-31 22:37:07 PDT

Created attachment 232335 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-06-01 01:12:26 PDT

Comment on attachment 232332 [details] Patch Attachment 232332 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6246356880457728 New failing tests: fast/inline/hidpi-selection-gap-overlaps-inline-selection.html fast/inline/hidpi-selection-gap-and-inline-selection-have-gap-rtl.html

Build Bot

Comment 7 2014-06-01 01:12:31 PDT

Created attachment 232340 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

alan

Comment 8 2014-06-01 07:40:03 PDT

Created attachment 232341 [details] Patch

alan

Comment 9 2014-06-01 07:40:22 PDT

Comment on attachment 232341 [details] Patch EWSing

WebKit Commit Bot

Comment 10 2014-06-01 09:31:29 PDT

Comment on attachment 232341 [details] Patch Clearing flags on attachment: 232341 Committed r169515: <http://trac.webkit.org/changeset/169515>

WebKit Commit Bot

Comment 11 2014-06-01 09:31:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.