| Summary: | Srcset refactoring to match spec changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yoav Weiss <yoav> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | bunhere, calvaris, commit-queue, eric.carlson, esprehn+autocc, gyuyoung.kim, philipj, pknight, rakuco, sergio | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Yoav Weiss
2014-05-30 14:36:51 PDT
Created attachment 232305 [details]
Patch
Attachment 232305 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5]
ERROR: LayoutTests/ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 4 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 232305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232305&action=review Patch is not compiling on Mac or Windows. I suggest breaking this patch up into two pieces. One patch can rearrange the code and refactor so it’s in a new location. The second patch should have the substantive change. It’s hard to successfully review a patch that both moves and changes code so it’s best to do the move and the change in two separate steps. > Source/JavaScriptCore/ChangeLog:6 > + Added a PICTURE_ELEMENT compile flag. Tabs not allowed in WebKit source files, including change log. > Source/WebCore/ChangeLog:3 > + Srcset refactoring to match spec changes Changing behavior is not “refactoring”, so this title is wrong. > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). This needs to be replaced by a line that doesn’t say “OOPS”. > LayoutTests/fast/hidpi/image-srcset-invalid-descriptor.html:7 > -<script src="../../resources/js-test.js"></script> > +<script src="../../resources/js-test-pre.js"></script> Why this change? It broke the test: we no longer get successfullyParsed. If we use pre.js then we also need to use post.js. Thanks for the review! :) I'll split up the patch into 2 as suggested and correct the review comments. |