Bug 133407 – Cleanup temporary setting of image interpolation quality in GraphicsContext::drawImage*

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

This is highly error prone with all the copy-paste code in GraphicsContext::drawImage, GraphicsContext::drawTiledImage, GraphicsContext::drawImageBuffer.

if (useLowQualityScale) {
       InterpolationQuality previousInterpolationQuality = imageInterpolationQuality();
       setImageInterpolationQuality(InterpolationNone);
       image->draw(this, styleColorSpace, dest, src, op, blendMode, useLowQualityScale);
       setImageInterpolationQuality(previousInterpolationQuality);
   } else
       image->draw(this, styleColorSpace, dest, src, op, blendMode, useLowQualityScale);

[zalan]

Created attachment 232301 [details]
Patch

[Darin Adler]

Comment on attachment 232301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232301&action=review

OK

> Source/WebCore/platform/graphics/GraphicsContext.cpp:98
> +    GraphicsContext* m_graphicsContext;

Should use a reference instead of a pointer.

> Source/WebCore/platform/graphics/GraphicsContext.cpp:100
> +    InterpolationQuality m_newInterpolationQuality;

Could just store a m_currentInterpolationQuality != m_newInterpolationQuality boolean instead.

[zalan]

(In reply to comment #2)
> (From update of attachment 232301 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232301&action=review
> 
> OK
> 
> > Source/WebCore/platform/graphics/GraphicsContext.cpp:98
> > +    GraphicsContext* m_graphicsContext;
> 
> Should use a reference instead of a pointer.
> 
> > Source/WebCore/platform/graphics/GraphicsContext.cpp:100
> > +    InterpolationQuality m_newInterpolationQuality;
> 
> Could just store a m_currentInterpolationQuality != m_newInterpolationQuality boolean instead.
Good point! I'll do that.

[zalan]

Created attachment 232303 [details]
Patch

[zalan]

Comment on attachment 232303 [details]
Patch

EWSing

[WebKit Commit Bot]

Comment on attachment 232303 [details]
Patch

Clearing flags on attachment: 232303

Committed r169498: <http://trac.webkit.org/changeset/169498>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.