| Summary: | WebCore build fix for webreplay | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zsolt Borbely <zsborbely.u-szeged> | ||||||||||||
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, burg, commit-queue, rniwa, timothy | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 232285 [details]
Proposed patch
Comment on attachment 232285 [details] Proposed patch Attachment 232285 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4809824537673728 New failing tests: media/W3C/audio/networkState/networkState_initial.html Created attachment 232291 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 232285 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=232285&action=review Thanks for fixing these little mistakes. AFAICT, the mac-wk2 failure should be unrelated, though tree is green now. > Source/WebCore/replay/SerializationMethods.cpp:49 > using WebCore::KeypressCommand; Can you instead move this into the other COCOA guarded statement below? Created attachment 232294 [details]
Proposed patch
Comment on attachment 232294 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=232294&action=review > Source/WebCore/replay/MemoizedDOMResult.cpp:60 > + default: > + RELEASE_ASSERT_NOT_REACHED(); > + return nullptr; This should be put outside the switch statement instead of in a default case. Adding a default case turns off the warning we get when we forget to handle a case, and we’d like to leave that on. Created attachment 232369 [details]
Proposed patch
Created attachment 232388 [details]
Patch for landing
Comment on attachment 232388 [details] Patch for landing Clearing flags on attachment: 232388 Committed r169544: <http://trac.webkit.org/changeset/169544> All reviewed patches have been landed. Closing bug. |
Tools/Scripts/build-webkit --efl --web-replay ... /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/MemoizedDOMResult.cpp: In static member function 'static std::unique_ptr<WebCore::MemoizedDOMResultBase> WebCore::MemoizedDOMResultBase::createFromEncodedResult(const WTF::String&, WebCore::EncodedCType, JSC::EncodedValue, WebCore::ExceptionCode)': /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/MemoizedDOMResult.cpp:58:1: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/SerializationMethods.cpp:48:16: error: 'WebCore::KeypressCommand' has not been declared /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/ReplayController.cpp: In member function 'void WebCore::ReplayController::setForceDeterministicSettings(bool)': /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/ReplayController.cpp:117:29: error: invalid use of incomplete type 'class WebCore::ScrollingCoordinator' In file included from /home/bzsolt/webkit/EflWebKit/Source/WebCore/inspector/InspectorInstrumentation.h:41:0, from /home/bzsolt/webkit/EflWebKit/Source/WebCore/replay/ReplayController.cpp:39: /home/bzsolt/webkit/EflWebKit/Source/WebCore/page/Page.h:100:7: error: forward declaration of 'class WebCore::ScrollingCoordinator'