| Summary: | Support -apple-system-font on OS X | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||
| Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | jonlee, mitz, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Myles C. Maxfield
2014-05-29 11:52:19 PDT
Created attachment 232257 [details]
Patch
Comment on attachment 232257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > LayoutTests/ChangeLog:11 > + * platform/mac/fast/text/apple-system-font-expected.html: Added. > + * platform/mac/fast/text/apple-system-font.html: Added. I think this ref test is bogus. You should extend the existing -webkit-system-font test. Comment on attachment 232257 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review > Source/WebCore/platform/mac/WebFontCache.mm:164 > - if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { > + if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame > + || [desiredFamily compare:@"-apple-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) { Can we use stringIsCaseInsensitiveEqualToString() here instead? http://trac.webkit.org/changeset/169474 Will use stringIsCaseInsensitiveEqualToString in a follow-up patch Addressed Mitz' comments in http://trac.webkit.org/changeset/169492 |