Bug 133382 – Support -apple-system-font on OS X

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

Support -apple-system-font on OS X

[Myles C. Maxfield]

Created attachment 232257 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 232257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review

> LayoutTests/ChangeLog:11
> +        * platform/mac/fast/text/apple-system-font-expected.html: Added.
> +        * platform/mac/fast/text/apple-system-font.html: Added.

I think this ref test is bogus. You should extend the existing -webkit-system-font test.

Comment on attachment 232257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232257&action=review

> Source/WebCore/platform/mac/WebFontCache.mm:164
> -    if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
> +    if ([desiredFamily compare:@"-webkit-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame
> +        || [desiredFamily compare:@"-apple-system-font" options:NSCaseInsensitiveSearch] == NSOrderedSame) {

Can we use stringIsCaseInsensitiveEqualToString() here instead?

[Myles C. Maxfield]

http://trac.webkit.org/changeset/169474

Will use stringIsCaseInsensitiveEqualToString in a follow-up patch

[Radar WebKit Bug Importer]

<rdar://problem/17080463>

[Myles C. Maxfield]

Addressed Mitz' comments in http://trac.webkit.org/changeset/169492