Bug 133377

Summary:

[GTK] Add support for HiDPI icons

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, rakuco, sergio

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

131562

Bug Blocks:

Attachments:

Description	Flags
Patch	mrobinson: review+

Description Carlos Garcia Campos 2014-05-29 07:28:57 PDT

We should use the @2x versions of the icons when device scale factor is >=2

Comment 1 Carlos Garcia Campos 2014-05-29 07:33:34 PDT

Created attachment 232248 [details]
Patch

Comment 2 Martin Robinson 2014-05-29 07:58:17 PDT

Comment on attachment 232248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review

> Source/WebKit2/PlatformGTK.cmake:520
> +    "        <file alias=\"images/deleteButton@2x\">deleteButton@2x.png</file>\n"
>      "        <file alias=\"images/missingImage\">missingImage.png</file>\n"
> +    "        <file alias=\"images/missingImage@2x\">missingImage@2x.png</file>\n"
>      "        <file alias=\"images/panIcon\">panIcon.png</file>\n"
>      "        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"
> +    "        <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"

Don't we need to add these files as well?

Comment 3 Carlos Garcia Campos 2014-05-29 08:00:51 PDT

(In reply to comment #2)
> (From update of attachment 232248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review
> 
> > Source/WebKit2/PlatformGTK.cmake:520
> > +    "        <file alias=\"images/deleteButton@2x\">deleteButton@2x.png</file>\n"
> >      "        <file alias=\"images/missingImage\">missingImage.png</file>\n"
> > +    "        <file alias=\"images/missingImage@2x\">missingImage@2x.png</file>\n"
> >      "        <file alias=\"images/panIcon\">panIcon.png</file>\n"
> >      "        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"
> > +    "        <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"
> 
> Don't we need to add these files as well?

What do you mean? add which ones? where?

Comment 4 Martin Robinson 2014-05-29 08:07:41 PDT

Comment on attachment 232248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review

>>> Source/WebKit2/PlatformGTK.cmake:520
>>> +    "        <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"
>> 
>> Don't we need to add these files as well?
> 
> What do you mean? add which ones? where?

I see now that they are already checked into the repository.

Comment 5 Carlos Garcia Campos 2014-05-29 08:11:48 PDT

(In reply to comment #4)
> (From update of attachment 232248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review
> 
> >>> Source/WebKit2/PlatformGTK.cmake:520
> >>> +    "        <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n"
> >> 
> >> Don't we need to add these files as well?
> > 
> > What do you mean? add which ones? where?
> 
> I see now that they are already checked into the repository.

Ah, you meant in the repo :-)

Comment 6 Carlos Garcia Campos 2014-05-29 09:06:16 PDT

Committed r169446: <http://trac.webkit.org/changeset/169446>