Summary: | [GTK] Add support for HiDPI icons | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, gyuyoung.kim, rakuco, sergio | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 131562 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-05-29 07:28:57 PDT
Created attachment 232248 [details]
Patch
Comment on attachment 232248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review > Source/WebKit2/PlatformGTK.cmake:520 > + " <file alias=\"images/deleteButton@2x\">deleteButton@2x.png</file>\n" > " <file alias=\"images/missingImage\">missingImage.png</file>\n" > + " <file alias=\"images/missingImage@2x\">missingImage@2x.png</file>\n" > " <file alias=\"images/panIcon\">panIcon.png</file>\n" > " <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n" > + " <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n" Don't we need to add these files as well? (In reply to comment #2) > (From update of attachment 232248 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review > > > Source/WebKit2/PlatformGTK.cmake:520 > > + " <file alias=\"images/deleteButton@2x\">deleteButton@2x.png</file>\n" > > " <file alias=\"images/missingImage\">missingImage.png</file>\n" > > + " <file alias=\"images/missingImage@2x\">missingImage@2x.png</file>\n" > > " <file alias=\"images/panIcon\">panIcon.png</file>\n" > > " <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n" > > + " <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n" > > Don't we need to add these files as well? What do you mean? add which ones? where? Comment on attachment 232248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review >>> Source/WebKit2/PlatformGTK.cmake:520 >>> + " <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n" >> >> Don't we need to add these files as well? > > What do you mean? add which ones? where? I see now that they are already checked into the repository. (In reply to comment #4) > (From update of attachment 232248 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review > > >>> Source/WebKit2/PlatformGTK.cmake:520 > >>> + " <file alias=\"images/textAreaResizeCorner@2x\">textAreaResizeCorner@2x.png</file>\n" > >> > >> Don't we need to add these files as well? > > > > What do you mean? add which ones? where? > > I see now that they are already checked into the repository. Ah, you meant in the repo :-) Committed r169446: <http://trac.webkit.org/changeset/169446> |