Bug 133377 – [GTK] Add support for HiDPI icons

• Component: Platform
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

We should use the @2x versions of the icons when device scale factor is >=2

[Carlos Garcia Campos]

Created attachment 232248 [details]
Patch

[Martin Robinson]

Comment on attachment 232248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review

> Source/WebKit2/PlatformGTK.cmake:520
> +    "        <file alias=\"images/deleteButton@2x\">[e-mail]</file>\n"
>      "        <file alias=\"images/missingImage\">missingImage.png</file>\n"
> +    "        <file alias=\"images/missingImage@2x\">[e-mail]</file>\n"
>      "        <file alias=\"images/panIcon\">panIcon.png</file>\n"
>      "        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"
> +    "        <file alias=\"images/textAreaResizeCorner@2x\">[e-mail]</file>\n"

Don't we need to add these files as well?

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 232248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review
> 
> > Source/WebKit2/PlatformGTK.cmake:520
> > +    "        <file alias=\"images/deleteButton@2x\">[e-mail]</file>\n"
> >      "        <file alias=\"images/missingImage\">missingImage.png</file>\n"
> > +    "        <file alias=\"images/missingImage@2x\">[e-mail]</file>\n"
> >      "        <file alias=\"images/panIcon\">panIcon.png</file>\n"
> >      "        <file alias=\"images/textAreaResizeCorner\">textAreaResizeCorner.png</file>\n"
> > +    "        <file alias=\"images/textAreaResizeCorner@2x\">[e-mail]</file>\n"
> 
> Don't we need to add these files as well?

What do you mean? add which ones? where?

[Martin Robinson]

Comment on attachment 232248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review

>>> Source/WebKit2/PlatformGTK.cmake:520
>>> +    "        <file alias=\"images/textAreaResizeCorner@2x\">[e-mail]</file>\n"
>> 
>> Don't we need to add these files as well?
> 
> What do you mean? add which ones? where?

I see now that they are already checked into the repository.

[Carlos Garcia Campos]

(In reply to comment #4)
> (From update of attachment 232248 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=232248&action=review
> 
> >>> Source/WebKit2/PlatformGTK.cmake:520
> >>> +    "        <file alias=\"images/textAreaResizeCorner@2x\">[e-mail]</file>\n"
> >> 
> >> Don't we need to add these files as well?
> > 
> > What do you mean? add which ones? where?
> 
> I see now that they are already checked into the repository.

Ah, you meant in the repo :-)

[Carlos Garcia Campos]

Committed r169446: <http://trac.webkit.org/changeset/169446>