Bug 133339

Summary: [Cocoa] Can't use bundle-defined classes for bundle parameters
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Decode bundle parameter after loading the bundle andersca: review+

Description mitz 2014-05-27 22:11:05 PDT
[Cocoa] Can't use bundle-defined classes for bundle parameters
Comment 1 mitz 2014-05-27 22:19:24 PDT
Created attachment 232170 [details]
Decode bundle parameter after loading the bundle
Comment 2 WebKit Commit Bot 2014-05-27 22:21:36 PDT
Attachment 232170 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:102:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:102:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2014-05-28 05:46:26 PDT
Comment on attachment 232170 [details]
Decode bundle parameter after loading the bundle

Very nice!
Comment 4 mitz 2014-05-28 07:29:35 PDT
Fixed in <http://trac.webkit.org/r169422>.