Bug 133234

Summary: Support inline caching of RegExpMatchesArray.length
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Andreas Kling 2014-05-23 14:16:12 PDT
We should IC RegExpMatchesArray.length just like we do JSArray.length
Comment 1 Andreas Kling 2014-05-23 14:17:19 PDT
Created attachment 231985 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-23 14:19:08 PDT
Attachment 231985 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-05-23 14:20:50 PDT
Created attachment 231987 [details]
Patch
Comment 4 Geoffrey Garen 2014-05-23 14:25:13 PDT
Comment on attachment 231987 [details]
Patch

r=me

Does attemptToMakeGetArrayLength work too?
Comment 5 Andreas Kling 2014-05-23 14:36:57 PDT
(In reply to comment #4)
> (From update of attachment 231987 [details])
> r=me
> 
> Does attemptToMakeGetArrayLength work too?

Don't know yet. I'm branching off that investigation into a separate patch.
Comment 6 WebKit Commit Bot 2014-05-23 15:14:21 PDT
Comment on attachment 231987 [details]
Patch

Clearing flags on attachment: 231987

Committed r169283: <http://trac.webkit.org/changeset/169283>
Comment 7 WebKit Commit Bot 2014-05-23 15:14:23 PDT
All reviewed patches have been landed.  Closing bug.