Bug 133234

Summary: Support inline caching of RegExpMatchesArray.length
Product: WebKit Reporter: Andreas Kling <kling>
Component: JavaScriptCoreAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andreas Kling
Reported 2014-05-23 14:16:12 PDT
We should IC RegExpMatchesArray.length just like we do JSArray.length
Attachments
Patch (2.78 KB, patch)
2014-05-23 14:17 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (2.78 KB, patch)
2014-05-23 14:20 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-05-23 14:17:19 PDT
Created attachment 231985 [details] Patch
WebKit Commit Bot
Comment 2 2014-05-23 14:19:08 PDT
Attachment 231985 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2014-05-23 14:20:50 PDT
Created attachment 231987 [details] Patch
Geoffrey Garen
Comment 4 2014-05-23 14:25:13 PDT
Comment on attachment 231987 [details] Patch r=me Does attemptToMakeGetArrayLength work too?
Andreas Kling
Comment 5 2014-05-23 14:36:57 PDT
(In reply to comment #4) > (From update of attachment 231987 [details]) > r=me > > Does attemptToMakeGetArrayLength work too? Don't know yet. I'm branching off that investigation into a separate patch.
WebKit Commit Bot
Comment 6 2014-05-23 15:14:21 PDT
Comment on attachment 231987 [details] Patch Clearing flags on attachment: 231987 Committed r169283: <http://trac.webkit.org/changeset/169283>
WebKit Commit Bot
Comment 7 2014-05-23 15:14:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.