Bug 133232

Summary: Remove invalid ASSERT in wordRangeForPosition
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Enrica Casucci
Reported 2014-05-23 13:57:23 PDT
In WK2 for iOS this function is called on every selection change. The selection could be set by Javascript in an element that is not visible. In that case we won't be able to create a VisiblePosition and wordRangeForPosition should not ASSERT that the VisiblePosition is not null, but rather perform an early return if it is null.
Attachments
Patch (1.64 KB, patch)
2014-05-23 14:00 PDT, Enrica Casucci 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2014-05-23 14:00:51 PDT
Created attachment 231981 [details] Patch
Enrica Casucci
Comment 2 2014-05-23 14:33:19 PDT
Committed revision 169280.
Note You need to log in before you can comment on or make changes to this bug.