Summary: | [EFL] Add LLVM as optional jhbuild module for FTL developers | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tibor Mészáros <mtiborinf> | ||||||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cgarcia, commit-queue, gyuyoung.kim, llango.u-szeged, lucas.de.marchi, rniwa, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Tibor Mészáros
2014-05-23 08:32:44 PDT
Created attachment 231965 [details]
Patch
This patch will add LLVM as optional jhbuild module for FTL developers
Sure 3.4 is enough? Building tip-of-tree JSC with that version fails. The GTK port is adding[1] the Subversion repository of LLVM to its Jhbuild optional moduleset, and will be checking out r133219 of that code, the same revision that Apple is building its LLVM libraries from[2]. There are still a lot of crashes with that revision of LLVM, so there's fun to be had. [1] Bug #133219. [2] http://trac.webkit.org/changeset/167334 and http://trac.webkit.org/changeset/167337 Comment on attachment 231965 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231965&action=review Yes, 3.4 is not enough nowadays, jsc required this commit http://llvm.org/viewvc/llvm-project?view=revision&revision=195173 that is not in 3.4. > Tools/efl/jhbuild.modules:136 > + autogenargs="--enable-optimized=yes --enable-backtraces=no --enable-targets=x86_64 --enable-zlib=no --enable-terminfo=no --enable-crash-overrides=no --disable-expensive-checks --disable-debug-runtime --disable-assertions"> hmm, I made jsc link to zlib and terminfo, aren't they really needed? In that case we should do the same in GTK, since it's indeed better and simpler. (In reply to comment #3) > (From update of attachment 231965 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=231965&action=review > > Yes, 3.4 is not enough nowadays, jsc required this commit http://llvm.org/viewvc/llvm-project?view=revision&revision=195173 that is not in 3.4. > > > Tools/efl/jhbuild.modules:136 > > + autogenargs="--enable-optimized=yes --enable-backtraces=no --enable-targets=x86_64 --enable-zlib=no --enable-terminfo=no --enable-crash-overrides=no --disable-expensive-checks --disable-debug-runtime --disable-assertions"> > > hmm, I made jsc link to zlib and terminfo, aren't they really needed? In that case we should do the same in GTK, since it's indeed better and simpler. As I know they aren't needed for FTL. Created attachment 232070 [details] Patch v2 I had added a Subversion repository of LLVM to its Jhbuild optional moduleset, and it will checking out r206311. LGTM Comment on attachment 232070 [details] Patch v2 Attachment 232070 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5145795535831040 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html Created attachment 232080 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 232070 [details]
Patch v2
r+ed based on internal review.
Comment on attachment 232070 [details] Patch v2 Clearing flags on attachment: 232070 Committed r169371: <http://trac.webkit.org/changeset/169371> All reviewed patches have been landed. Closing bug. |