Bug 133213

Summary: [CSS Grid Layout] Use gridRowCount() and gridColumnCount() when possible
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: CSSAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, jfernandez, kondapallykalyan, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Description Manuel Rego Casasnovas 2014-05-23 05:09:52 PDT 
We're not being consistent in RenderGrid code and sometimes we use m_grid.size() and other gridRowCount() (and the same for columns).

This is a simple patch to use gridRowCount() and gridColumnCount() always when it's possible. Which will make the code more descriptive and easier to understand.

BTW, a similar patch has already landed in Blink: https://codereview.chromium.org/235713003/
Comment 1 Manuel Rego Casasnovas 2014-05-23 05:19:32 PDT 
Created attachment 231958 [details]
Patch
Comment 2 Sergio Villar Senin 2014-05-23 08:13:01 PDT 
Comment on attachment 231958 [details]
Patch

Nice cleanup
Comment 3 WebKit Commit Bot 2014-05-23 13:31:51 PDT 
Comment on attachment 231958 [details]
Patch

Clearing flags on attachment: 231958

Committed r169277: <http://trac.webkit.org/changeset/169277>
Comment 4 WebKit Commit Bot 2014-05-23 13:31:54 PDT 
All reviewed patches have been landed.  Closing bug.