Bug 133154

Summary:

Allow building CMake based ports with WEB_REPLAY

Product:

WebKit

Reporter:

Zsolt Borbely <zsborbely.u-szeged>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, bunhere, burg, commit-queue, gyuyoung.kim, ossy, rakuco, rniwa, sergio, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none
Proposed patch	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none

Zsolt Borbely

Reported 2014-05-21 08:12:33 PDT

Allow building CMake based ports with WEB_REPLAY

Attachments
Proposed patch (6.65 KB, patch) 2014-05-21 08:20 PDT, Zsolt Borbely	no flags	Details Formatted Diff Diff
Proposed patch (6.75 KB, patch) 2014-05-21 23:43 PDT, Zsolt Borbely	no flags	Details Formatted Diff Diff
Proposed patch (6.71 KB, patch) 2014-05-22 01:53 PDT, Zsolt Borbely	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (1.03 MB, application/zip) 2014-05-22 08:00 PDT, Build Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Zsolt Borbely

Comment 1 2014-05-21 08:20:00 PDT

Created attachment 231830 [details] Proposed patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2014-05-21 09:31:12 PDT

Comment on attachment 231830 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231830&action=review > Source/JavaScriptCore/CMakeLists.txt:909 > + nit: extra empty line.

Zsolt Borbely

Comment 3 2014-05-21 23:43:03 PDT

Created attachment 231863 [details] Proposed patch

Gyuyoung Kim

Comment 4 2014-05-22 01:01:37 PDT

Comment on attachment 231863 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231863&action=review > Source/JavaScriptCore/CMakeLists.txt:924 > + Looks unnecessary a blank line. > Source/WebCore/CMakeLists.txt:3147 > + replay/MemoizedDOMResult.cpp Wrong alphabet order. > Source/WebCore/CMakeLists.txt:3150 > + replay/CapturingInputCursor.cpp ditto. > Source/WebCore/CMakeLists.txt:3151 > + replay/SerializationMethods.cpp ditto. > Source/WebCore/CMakeLists.txt:3157 > + replay/EventLoopInputDispatcher.cpp ditto.

Zsolt Borbely

Comment 5 2014-05-22 01:53:32 PDT

Created attachment 231869 [details] Proposed patch

Build Bot

Comment 6 2014-05-22 08:00:11 PDT

Comment on attachment 231869 [details] Proposed patch Attachment 231869 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5444384883474432 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/table-type-after.html

Build Bot

Comment 7 2014-05-22 08:00:19 PDT

Created attachment 231887 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Brian Burg

Comment 8 2014-05-22 08:34:46 PDT

Hi, It is fine to allow building this flag---thanks for hooking it up! But, work on the feature is effectively on hold until mid-June when both myself and reviewers have more time.

Zsolt Borbely

Comment 9 2014-05-23 02:19:58 PDT

Comment on attachment 231869 [details] Proposed patch Mac WK2 buildbots are red on trunk, the reported failures is unrelated to this patch.

Csaba Osztrogonác

Comment 10 2014-05-27 04:00:55 PDT

Comment on attachment 231869 [details] Proposed patch LGTM, r=me

WebKit Commit Bot

Comment 11 2014-05-27 04:31:47 PDT

Comment on attachment 231869 [details] Proposed patch Clearing flags on attachment: 231869 Committed r169379: <http://trac.webkit.org/changeset/169379>

WebKit Commit Bot

Comment 12 2014-05-27 04:31:53 PDT

All reviewed patches have been landed. Closing bug.

Brian Burg

Comment 13 2014-05-27 09:38:07 PDT

Thanks for taking this up! I'll be sure to add new replay-related sources to CMakeLists.txt

Note You need to log in before you can comment on or make changes to this bug.