| Summary: | Allow building CMake based ports with WEB_REPLAY | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zsolt Borbely <zsborbely.u-szeged> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | buildbot, bunhere, burg, commit-queue, gyuyoung.kim, ossy, rakuco, rniwa, sergio, timothy | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Zsolt Borbely
2014-05-21 08:12:33 PDT
Created attachment 231830 [details]
Proposed patch
Comment on attachment 231830 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231830&action=review > Source/JavaScriptCore/CMakeLists.txt:909 > + nit: extra empty line. Created attachment 231863 [details]
Proposed patch
Comment on attachment 231863 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=231863&action=review > Source/JavaScriptCore/CMakeLists.txt:924 > + Looks unnecessary a blank line. > Source/WebCore/CMakeLists.txt:3147 > + replay/MemoizedDOMResult.cpp Wrong alphabet order. > Source/WebCore/CMakeLists.txt:3150 > + replay/CapturingInputCursor.cpp ditto. > Source/WebCore/CMakeLists.txt:3151 > + replay/SerializationMethods.cpp ditto. > Source/WebCore/CMakeLists.txt:3157 > + replay/EventLoopInputDispatcher.cpp ditto. Created attachment 231869 [details]
Proposed patch
Comment on attachment 231869 [details] Proposed patch Attachment 231869 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5444384883474432 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/table-type-after.html Created attachment 231887 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Hi, It is fine to allow building this flag---thanks for hooking it up! But, work on the feature is effectively on hold until mid-June when both myself and reviewers have more time. Comment on attachment 231869 [details]
Proposed patch
Mac WK2 buildbots are red on trunk, the reported failures is unrelated to this patch.
Comment on attachment 231869 [details]
Proposed patch
LGTM, r=me
Comment on attachment 231869 [details] Proposed patch Clearing flags on attachment: 231869 Committed r169379: <http://trac.webkit.org/changeset/169379> All reviewed patches have been landed. Closing bug. Thanks for taking this up! I'll be sure to add new replay-related sources to CMakeLists.txt |