Summary: | Garbage when rubber-banding at the right edge of a page zoomed to non-integral scale. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mhahnenberg, rniwa, sergio, simon.fraser, thorton | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
zalan
2014-05-20 16:33:22 PDT
Created attachment 231809 [details]
Patch
Comment on attachment 231809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231809&action=review > Source/WebCore/rendering/RenderLayerBacking.h:198 > + virtual bool needsPixelAligment() const override final; can't this whole class be final? Comment on attachment 231809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231809&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:2325 > + return !(m_owningLayer.isRootLayer() && renderer().frame().isMainFrame()); I think you should just return m_usingTiledCacheLayer. Comment on attachment 231809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231809&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=133139 Please list some radars here. Created attachment 231811 [details]
Patch
Comment on attachment 231811 [details]
Patch
EWSing
Comment on attachment 231811 [details] Patch Attachment 231811 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6197641348120576 New failing tests: editing/unsupported-content/list-type-before.html editing/unsupported-content/table-type-before.html editing/unsupported-content/list-delete-003.html editing/unsupported-content/list-delete-001.html editing/unsupported-content/list-type-after.html platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html editing/unsupported-content/table-delete-002.html editing/unsupported-content/table-type-after.html Created attachment 231817 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 231824 [details]
Patch
Comment on attachment 231824 [details]
Patch
EWS again.
Comment on attachment 231824 [details]
Patch
EWS again.
Comment on attachment 231824 [details] Patch Clearing flags on attachment: 231824 Committed r169161: <http://trac.webkit.org/changeset/169161> All reviewed patches have been landed. Closing bug. (In reply to comment #12) > (From update of attachment 231824 [details]) > Clearing flags on attachment: 231824 > > Committed r169161: <http://trac.webkit.org/changeset/169161> It looks like this caused platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html to start failing on the bots. Here's the results on the Mavericks bot: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169162%20(5869)/results.html Here's the history of the bot which shows that it started failing reliably after this revision: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=100 (In reply to comment #14) > (In reply to comment #12) > > (From update of attachment 231824 [details] [details]) > > Clearing flags on attachment: 231824 > > > > Committed r169161: <http://trac.webkit.org/changeset/169161> > > It looks like this caused platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed.html to start failing on the bots. > > Here's the results on the Mavericks bot: http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r169162%20(5869)/results.html > > Here's the history of the bot which shows that it started failing reliably after this revision: http://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20%28Tests%29?numbuilds=100 Nevermind, the results were re-baselined in a later fix. |