Bug 13312

Summary:

portable implementation of <canvas> element

Product:

WebKit

Reporter:

Mike Reed <mikerreed>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gavin.sharp, mrowe, staikos

Priority:

Version:

523.x (Safari 3)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch.txt and a new platform header PlatformGraphics.h	mrowe: review-

Mike Reed

Reported 2007-04-09 11:14:33 PDT

This patch extends GraphicsContext.h to have the necessary entry points to implement <canvas>. The patch is done by #else clauses whereever there was #if PLATFORM(CG) specific code used for <canvas>.

Attachments
patch.txt and a new platform header PlatformGraphics.h (4.91 KB, patch) 2007-04-09 11:19 PDT, Mike Reed	mrowe: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mike Reed

Comment 1 2007-04-09 11:19:16 PDT

Created attachment 13993 [details] patch.txt and a new platform header PlatformGraphics.h

Mark Rowe (bdash)

Comment 2 2007-04-09 16:43:57 PDT

Can you please attach the change as a diff created with svn-create-patch (in WebKitTools/Scripts) rather than a zip file? A ChangeLog entry should also be included (use prepare-ChangeLog to generate a template). If you would like this patch to be reviewed and landed, you should select the "review ?" flag after attaching the patch.

Dave Hyatt

Comment 3 2007-04-09 16:48:14 PDT

(This hasn't been flagged for review, but I should point out that this would not be appropriate for landing until after the stabilization period is over.)

Mark Rowe (bdash)

Comment 4 2007-04-25 05:03:06 PDT

Mike, are you able to attach an updated patch in the correct format?

Mark Rowe (bdash)

Comment 5 2007-04-25 05:40:16 PDT

Comment on attachment 13993 [details] patch.txt and a new platform header PlatformGraphics.h The big issue here is the addition of many new methods to GraphicsContext with no implementations. This will break all non-CoreGraphics builds, and at the very least these should be stubbed out. A ChangeLog entry and the necessary project file changes would also be great. Besides that there are some minor code style issues I noticed while skimming the patch: the local variable "pg" in CanvasGradient::platformGradient seems unnecessary and the placement of braces is incorrect, the declaration of "count" has been manually lined up with "data", one of the changes in HTMLCanvasElement.cpp adds unnecessary braces.

George Staikos

Comment 6 2007-07-06 10:51:17 PDT

Would like to get this one moving along again. The current situation is quite ugly.

Eric Seidel (no email)

Comment 7 2007-10-01 09:43:35 PDT

This could easily go on the feature-branch, once the patch is dusted off again.

Eric Seidel (no email)

Comment 8 2008-09-30 20:27:37 PDT

Mike, this has all been done in the latest sources.

Note You need to log in before you can comment on or make changes to this bug.