Summary: | http/tests/navigation/forward-to-fragment-fires-onload.html asserts | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jonathan Wells <jonowells> | ||||||
Component: | Tools / Tests | Assignee: | Anders Carlsson <andersca> | ||||||
Status: | REOPENED --- | ||||||||
Severity: | Normal | CC: | aestes, andersca, ap, commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Jonathan Wells
2014-05-19 09:51:35 PDT
Created attachment 231697 [details]
Patch
Comment on attachment 231697 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=231697&action=review > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:11 > -description('Tests that loading is not stopped by going forward to a fragment.'); > +description("Tests to see that loading is not stopped by going forward to a fragment."); I wouldn't change these to double quotes. It'll just make it harder for someone to blame this file later on. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:17 > - if (window.localStorage.stage == 'three') { > - console.log('3. Got back to start. Going forward to page 2.'); > - window.localStorage.stage = 'four'; > + if (window.localStorage.stage == "three") { > + console.log("3. Got back to start. Going forward to page 2."); > + window.localStorage.stage = "four"; Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:19 > - } else if (window.localStorage.stage == 'six') { > + } else if (window.localStorage.stage == "six") { Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:27 > - console.log('Starting test.'); > - window.localStorage.stage = 'one'; > + console.log("Starting test."); > + window.localStorage.stage = "one"; Ditto. > LayoutTests/http/tests/navigation/forward-to-fragment-fires-onload.html:30 > - window.location.href = 'resources/forward-to-fragment-fires-onload-2.html'; > + window.location.href = "resources/forward-to-fragment-fires-onload-2.html"; Ditto. Created attachment 231698 [details]
Patch
This test crashes on bots - is there more to the bug than the paths? http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK2%20(Tests)/r169042%20(17740)/http/tests/navigation/forward-to-fragment-fires-onload-crash-log.txt Comment on attachment 231698 [details] Patch Clearing flags on attachment: 231698 Committed r169050: <http://trac.webkit.org/changeset/169050> All reviewed patches have been landed. Closing bug. I ran the tests and didn't have a crash or failure on this test anymore. However http/tests/navigation/resources/forward-to-fragment-fires-onload-2.html has a closing </iframe> tag that seems out of place. Reopening as crash still occurring. I think this was caused by http://trac.webkit.org/changeset/169026. The assertion was removed in <http://trac.webkit.org/changeset/169292>. As far as I can tell, that was done temporarily, and the assertion needs to be re-added. |