Bug 133068

Summary: Only set title on SVG documents
Product: WebKit Reporter: Prashant Hiremath <hiremathprashants>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, fmalita, gyuyoung.kim, jose.lejin, krit, pdr, schenney, sergio, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Prashant Hiremath
Reported 2014-05-19 06:43:15 PDT
We should set title on only SVG documents, HTML document should not be affected. Blink, IE and FF behaves similarly. We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision I'll update the patch soon...
Attachments
Patch (3.65 KB, patch)
2014-05-19 07:07 PDT, Prashant Hiremath 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Prashant Hiremath
Comment 1 2014-05-19 07:07:07 PDT
Created attachment 231686 [details] Patch proposed patch
Dirk Schulze
Comment 2 2014-05-19 07:49:25 PDT
(In reply to comment #0) > We should set title on only SVG documents, HTML document should not be affected. > > Blink, IE and FF behaves similarly. > > We should merge recent blink Merge https://src.chromium.org/viewvc/blink?revision=174123&view=revision > > I'll update the patch soon... No we shouldn't. The SVG guidance still says that <title> can be set on groups and elements. In how far <title> is still important is questionable. Until then we should maybe fix title, but not just let it apply to document.
Dirk Schulze
Comment 3 2014-05-20 09:44:24 PDT
Comment on attachment 231686 [details] Patch Totally misunderstood the purpose. r=me
WebKit Commit Bot
Comment 4 2014-05-20 10:14:05 PDT
Comment on attachment 231686 [details] Patch Clearing flags on attachment: 231686 Committed r169118: <http://trac.webkit.org/changeset/169118>
WebKit Commit Bot
Comment 5 2014-05-20 10:14:10 PDT
All reviewed patches have been landed. Closing bug.
Dirk Schulze
Comment 6 2014-05-20 10:21:21 PDT
Hm, I just noticed that is was back ported from Blink. These kind of things should be part of the ChangeLog and the original author should get the credits.
Note You need to log in before you can comment on or make changes to this bug.