Bug 133047

Summary:

REGRESSION(r163712): [GTK] Misspelling and grammar underline marks are no longer drawn

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

Text

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, berto, darin, mrobinson

Priority:

Keywords:

Gtk, Regression

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	darin: review+

Description Carlos Garcia Campos 2014-05-18 03:06:10 PDT

In epiphany I can see the suggestions in the context menu, so it seems the spellchecker is working, but the document marks are not correctly drawn. It works with WebKitGTK+ 2.4.x.

Comment 1 Alberto Garcia 2014-05-20 00:26:44 PDT

I'll take a look

Comment 2 Alberto Garcia 2014-05-20 04:48:06 PDT

The regression was introduced in r163712:

    Change TextIterator to use StringView, preparing to wean it from deprecatedCharacters
    https://bugs.webkit.org/show_bug.cgi?id=128233

Comment 3 Carlos Garcia Campos 2014-05-22 07:01:29 PDT

Created attachment 231883 [details]
Patch

I've also changed the whole loop, using a for loop instead, so that we can use the current condition but to continue the loop. I think it improves the readability.

Comment 4 Carlos Garcia Campos 2014-05-22 09:23:43 PDT

Committed r169203: <http://trac.webkit.org/changeset/169203>