Bug 133032

Summary: NetworkProcess can repeatedly crash handling Blob messages after any unrelated crash
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, beidson, commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Alexey Proskuryakov
Reported 2014-05-17 13:39:46 PDT
Some code in NetworkBlobRegistry assumes that a connection handler is already registered when executing unregisterBlob(). Normally this is is indeed the case, as WebProcess won't try to unregister a blob that it didn't register. But if we previously lost the whole registry due to an unrelated NetworkProcess crash, then this invariant doesn't hold. In fact, we already have some of these functions check for connection, but not all. <rdar://problem/16951630>
Attachments
proposed fix (3.58 KB, patch)
2014-05-17 13:42 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-05-17 13:42:37 PDT
Created attachment 231637 [details] proposed fix
Geoffrey Garen
Comment 2 2014-05-17 14:08:42 PDT
Comment on attachment 231637 [details] proposed fix r=me
WebKit Commit Bot
Comment 3 2014-05-17 14:43:13 PDT
Comment on attachment 231637 [details] proposed fix Clearing flags on attachment: 231637 Committed r168997: <http://trac.webkit.org/changeset/168997>
WebKit Commit Bot
Comment 4 2014-05-17 14:43:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.